Check m_nComponents when using JBIG2Decode

Check m_nComponents when using JBIG2Decode

BUG=409692
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5f8a503b2a8701c5c4f6e0aadf334affcdd03d28

[Bo Xu, 2014-09-02 21:26:19]

bo_xu@foxitsoftware.com changed reviewers:
+ jun_fang@foxitsoftware.com, tsepez@chromium.org

[Bo Xu, 2014-09-02 21:26:20]

Tom, please review this one.

[Tom Sepez, 2014-09-02 21:32:31]

LGTM with nit.

https://codereview.chromium.org/534763002/diff/1/core/src/fpdfapi/fpdf_render...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/534763002/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:348: 
nit: no blank line here.

[Bo Xu, 2014-09-02 22:01:10]

On 2014/09/02 21:32:31, Tom Sepez wrote:
> LGTM with nit.
> 
>
https://codereview.chromium.org/534763002/diff/1/core/src/fpdfapi/fpdf_render...
> File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):
> 
>
https://codereview.chromium.org/534763002/diff/1/core/src/fpdfapi/fpdf_render...
> core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:348: 
> nit: no blank line here.

Thanks Tom. 

I realized we may want to put all the check to ValidateDictParam (previously
ValidateBpc) at the beginning of loading DIB source in LoadColorInfo.If there
are new issues like these, we can put the check all in here.

Let me know if the new patch looks good to you.

[Tom Sepez, 2014-09-02 22:11:48]

LGTM with new nits.

[Tom Sepez, 2014-09-02 22:11:55]

https://codereview.chromium.org/534763002/diff/60001/core/src/fpdfapi/fpdf_re...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/534763002/diff/60001/core/src/fpdfapi/fpdf_re...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:500: m_bpc_orig =
m_pDict->GetInteger(FX_BSTRC("BitsPerComponent"));
Maybe this assignment goes as the first line of ValidateDictParams().

https://codereview.chromium.org/534763002/diff/60001/core/src/fpdfapi/fpdf_re...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:915: CPDF_Object *
pFilter = m_pDict ? m_pDict->GetElementValue(FX_BSTRC("Filter")) : NULL;
nit: we de-ref'd m_pDict just before calling this method, hence it cant be NULL.

[Bo Xu, 2014-09-02 22:27:13]

https://codereview.chromium.org/534763002/diff/60001/core/src/fpdfapi/fpdf_re...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/534763002/diff/60001/core/src/fpdfapi/fpdf_re...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:500: m_bpc_orig =
m_pDict->GetInteger(FX_BSTRC("BitsPerComponent"));
On 2014/09/02 22:11:54, Tom Sepez wrote:
> Maybe this assignment goes as the first line of ValidateDictParams().

Done.

https://codereview.chromium.org/534763002/diff/60001/core/src/fpdfapi/fpdf_re...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:915: CPDF_Object *
pFilter = m_pDict ? m_pDict->GetElementValue(FX_BSTRC("Filter")) : NULL;
On 2014/09/02 22:11:54, Tom Sepez wrote:
> nit: we de-ref'd m_pDict just before calling this method, hence it cant be
NULL.

Now check m_pDict in CPDF_DIBSource::Load to make sure m_pDict is not NULL here
and in LoadColorInfo()

[Tom Sepez, 2014-09-02 22:35:27]

lgtm

[Bo Xu, 2014-09-02 22:36:33]

Committed patchset #5 (id:80001) manually as 5f8a503 (presubmit successful).