Issue 534733002: Revert "[Sync] Move DataTypeStatusTable ownership into DataTypeManager."

Issue 534733002: Revert "[Sync] Move DataTypeStatusTable ownership into DataTypeManager." (Closed)

Created:
6 years, 3 months ago by dmazzoni

Modified:
6 years, 3 months ago

Reviewers:
(dont use) zea at google, scottmg

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "[Sync] Move DataTypeStatusTable ownership into DataTypeManager." This reverts commit fe2ae5fbf23243039bdc94f8f8672bc371f5339f. BUG=368834, 409965 TBR=zea,scottmg Committed: https://chromium.googlesource.com/chromium/src/+/6513171d7473b9eb60e1bf16369cf893daa33a07

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+209 lines, -408 lines)			Patch
D	chrome/browser/sync/glue/history_delete_directives_data_type_controller.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/sync/glue/history_delete_directives_data_type_controller.cc	View	1 chunk	+0 lines, -49 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View	5 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_mock.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	5 chunks	+29 lines, -8 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_autofill_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_startup_unittest.cc	View	9 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/test/integration/sync_errors_test.cc	View	2 chunks	+6 lines, -27 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/sync_driver/data_type_manager.h	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	components/sync_driver/data_type_manager_impl.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	components/sync_driver/data_type_manager_impl.cc	View	12 chunks	+22 lines, -27 lines	0 comments	Download
M	components/sync_driver/data_type_manager_impl_unittest.cc	View	44 chunks	+105 lines, -206 lines	0 comments	Download
M	components/sync_driver/data_type_manager_mock.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/sync_driver/data_type_status_table.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/sync_driver/fake_data_type_controller.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

Committed patchset #1 (id:1) manually as 6513171 (presubmit successful).

6 years, 3 months ago (2014-09-02 20:06:32 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:20:14 UTC) #3

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6513171d7473b9eb60e1bf16369cf893daa33a07
Cr-Commit-Position: refs/heads/master@{#292981}

Expand Messages | Collapse Messages