Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory.h

Issue 534733002: Revert "[Sync] Move DataTypeStatusTable ownership into DataTypeManager." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 80
81 // Instantiates a new DataTypeManager with a SyncBackendHost, a list of data 81 // Instantiates a new DataTypeManager with a SyncBackendHost, a list of data
82 // type controllers and a DataTypeManagerObserver. The return pointer is 82 // type controllers and a DataTypeManagerObserver. The return pointer is
83 // owned by the caller. 83 // owned by the caller.
84 virtual sync_driver::DataTypeManager* CreateDataTypeManager( 84 virtual sync_driver::DataTypeManager* CreateDataTypeManager(
85 const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>& 85 const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>&
86 debug_info_listener, 86 debug_info_listener,
87 const sync_driver::DataTypeController::TypeMap* controllers, 87 const sync_driver::DataTypeController::TypeMap* controllers,
88 const sync_driver::DataTypeEncryptionHandler* encryption_handler, 88 const sync_driver::DataTypeEncryptionHandler* encryption_handler,
89 browser_sync::SyncBackendHost* backend, 89 browser_sync::SyncBackendHost* backend,
90 sync_driver::DataTypeManagerObserver* observer) = 0; 90 sync_driver::DataTypeManagerObserver* observer,
91 sync_driver::DataTypeStatusTable* data_type_status_table) = 0;
91 92
92 // Creating this in the factory helps us mock it out in testing. 93 // Creating this in the factory helps us mock it out in testing.
93 virtual browser_sync::SyncBackendHost* CreateSyncBackendHost( 94 virtual browser_sync::SyncBackendHost* CreateSyncBackendHost(
94 const std::string& name, 95 const std::string& name,
95 Profile* profile, 96 Profile* profile,
96 invalidation::InvalidationService* invalidator, 97 invalidation::InvalidationService* invalidator,
97 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs, 98 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs,
98 const base::FilePath& sync_folder) = 0; 99 const base::FilePath& sync_folder) = 0;
99 100
100 // Creating this in the factory helps us mock it out in testing. 101 // Creating this in the factory helps us mock it out in testing.
101 virtual scoped_ptr<browser_sync::LocalDeviceInfoProvider> 102 virtual scoped_ptr<browser_sync::LocalDeviceInfoProvider>
102 CreateLocalDeviceInfoProvider() = 0; 103 CreateLocalDeviceInfoProvider() = 0;
103 104
104 // Legacy datatypes that need to be converted to the SyncableService API. 105 // Legacy datatypes that need to be converted to the SyncableService API.
105 virtual SyncComponents CreateBookmarkSyncComponents( 106 virtual SyncComponents CreateBookmarkSyncComponents(
106 ProfileSyncService* profile_sync_service, 107 ProfileSyncService* profile_sync_service,
107 sync_driver::DataTypeErrorHandler* error_handler) = 0; 108 sync_driver::DataTypeErrorHandler* error_handler) = 0;
108 virtual SyncComponents CreateTypedUrlSyncComponents( 109 virtual SyncComponents CreateTypedUrlSyncComponents(
109 ProfileSyncService* profile_sync_service, 110 ProfileSyncService* profile_sync_service,
110 history::HistoryBackend* history_backend, 111 history::HistoryBackend* history_backend,
111 sync_driver::DataTypeErrorHandler* error_handler) = 0; 112 sync_driver::DataTypeErrorHandler* error_handler) = 0;
112 }; 113 };
113 114
114 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__ 115 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698