Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 53453004: Remove virtual where not needed in HTMLMediaElement/HTMLVideoElement (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
Mike West, eae
CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove virtual where not needed in HTMLMediaElement/HTMLVideoElement These functions were neither overrides or overridden anywhere, so the virtual keywords were likely copypasta or unrealized plans. BUG=313702 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161166

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/html/HTMLMediaElement.h View 3 chunks +4 lines, -4 lines 2 comments Download
M Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years, 1 month ago (2013-10-31 21:25:45 UTC) #1
Mike West
LGTM https://codereview.chromium.org/53453004/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/53453004/diff/1/Source/core/html/HTMLMediaElement.h#newcode230 Source/core/html/HTMLMediaElement.h:230: void textTrackReadyStateChanged(TextTrack*); Why move this?
7 years, 1 month ago (2013-11-01 10:31:23 UTC) #2
philipj_slow
https://codereview.chromium.org/53453004/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/53453004/diff/1/Source/core/html/HTMLMediaElement.h#newcode230 Source/core/html/HTMLMediaElement.h:230: void textTrackReadyStateChanged(TextTrack*); On 2013/11/01 10:31:23, Mike West wrote: > ...
7 years, 1 month ago (2013-11-01 10:37:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/53453004/1
7 years, 1 month ago (2013-11-01 14:08:52 UTC) #4
commit-bot: I haz the power
Change committed as 161166
7 years, 1 month ago (2013-11-01 15:12:25 UTC) #5
eae
7 years, 1 month ago (2013-11-01 17:51:33 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698