Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 53453004: Remove virtual where not needed in HTMLMediaElement/HTMLVideoElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLVideoElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 68b241619ab89d2f801537d9ade7eef8625f9d9b..329b5616cb866b64bfea6de458c88d8faaf54aff 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -85,7 +85,7 @@ public:
// Eventually overloaded in HTMLVideoElement
virtual bool supportsFullscreen() const OVERRIDE { return false; };
- virtual bool supportsSave() const;
+ bool supportsSave() const;
WebKit::WebLayer* platformLayer() const;
@@ -192,8 +192,8 @@ public:
void closeCaptionTracksChanged();
void notifyMediaPlayerOfTextTrackChanges();
- virtual void didAddTrack(HTMLTrackElement*);
- virtual void didRemoveTrack(HTMLTrackElement*);
+ void didAddTrack(HTMLTrackElement*);
+ void didRemoveTrack(HTMLTrackElement*);
virtual void mediaPlayerDidAddTrack(PassRefPtr<InbandTextTrackPrivate>) OVERRIDE;
virtual void mediaPlayerDidRemoveTrack(PassRefPtr<InbandTextTrackPrivate>) OVERRIDE;
@@ -227,9 +227,9 @@ public:
};
void configureTextTrackDisplay(VisibilityChangeAssumption);
void updateTextTrackDisplay();
+ void textTrackReadyStateChanged(TextTrack*);
Mike West 2013/11/01 10:31:23 Why move this?
philipj_slow 2013/11/01 10:37:27 To make it clear that it isn't actually part of th
// TextTrackClient
- virtual void textTrackReadyStateChanged(TextTrack*);
virtual void textTrackKindChanged(TextTrack*) OVERRIDE;
virtual void textTrackModeChanged(TextTrack*) OVERRIDE;
virtual void textTrackAddCues(TextTrack*, const TextTrackCueList*) OVERRIDE;
« no previous file with comments | « no previous file | Source/core/html/HTMLVideoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698