 Chromium Code Reviews
 Chromium Code Reviews Issue 53453004:
  Remove virtual where not needed in HTMLMediaElement/HTMLVideoElement  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 53453004:
  Remove virtual where not needed in HTMLMediaElement/HTMLVideoElement  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/html/HTMLMediaElement.h | 
| diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h | 
| index 68b241619ab89d2f801537d9ade7eef8625f9d9b..329b5616cb866b64bfea6de458c88d8faaf54aff 100644 | 
| --- a/Source/core/html/HTMLMediaElement.h | 
| +++ b/Source/core/html/HTMLMediaElement.h | 
| @@ -85,7 +85,7 @@ public: | 
| // Eventually overloaded in HTMLVideoElement | 
| virtual bool supportsFullscreen() const OVERRIDE { return false; }; | 
| - virtual bool supportsSave() const; | 
| + bool supportsSave() const; | 
| WebKit::WebLayer* platformLayer() const; | 
| @@ -192,8 +192,8 @@ public: | 
| void closeCaptionTracksChanged(); | 
| void notifyMediaPlayerOfTextTrackChanges(); | 
| - virtual void didAddTrack(HTMLTrackElement*); | 
| - virtual void didRemoveTrack(HTMLTrackElement*); | 
| + void didAddTrack(HTMLTrackElement*); | 
| + void didRemoveTrack(HTMLTrackElement*); | 
| virtual void mediaPlayerDidAddTrack(PassRefPtr<InbandTextTrackPrivate>) OVERRIDE; | 
| virtual void mediaPlayerDidRemoveTrack(PassRefPtr<InbandTextTrackPrivate>) OVERRIDE; | 
| @@ -227,9 +227,9 @@ public: | 
| }; | 
| void configureTextTrackDisplay(VisibilityChangeAssumption); | 
| void updateTextTrackDisplay(); | 
| + void textTrackReadyStateChanged(TextTrack*); | 
| 
Mike West
2013/11/01 10:31:23
Why move this?
 
philipj_slow
2013/11/01 10:37:27
To make it clear that it isn't actually part of th
 | 
| // TextTrackClient | 
| - virtual void textTrackReadyStateChanged(TextTrack*); | 
| virtual void textTrackKindChanged(TextTrack*) OVERRIDE; | 
| virtual void textTrackModeChanged(TextTrack*) OVERRIDE; | 
| virtual void textTrackAddCues(TextTrack*, const TextTrackCueList*) OVERRIDE; |