Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 534383003: Fix warning for multi line comment in QUIC. (Closed)

Created:
6 years, 3 months ago by elecro
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ramant (doing other things)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix warning for multi line comment in QUIC. Removed tailing \ character from the example usage to make GCC to forget the multi-line comment warning. BUG=410777 TEST=build with gcc Committed: https://crrev.com/5cf5e939b7e43e2fed394058d892605bb3adb2c3 Cr-Commit-Position: refs/heads/master@{#293334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
elecro
Removed trailing \ character from single line comment, just like it was before the https://codereview.chromium.org/530343003 ...
6 years, 3 months ago (2014-09-04 11:40:27 UTC) #2
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-09-04 16:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/534383003/1
6 years, 3 months ago (2014-09-04 17:02:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 436aaffe6c30e7eb640a3b94431037a58f214bd8
6 years, 3 months ago (2014-09-04 21:03:33 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cf5e939b7e43e2fed394058d892605bb3adb2c3
Cr-Commit-Position: refs/heads/master@{#293334}

Powered by Google App Engine
This is Rietveld 408576698