Issue 534363003: Merge: Show search box on settings page in ChromeOS guest mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 534363003: Merge: Show search box on settings page in ChromeOS guest mode. (Closed)

Created:
6 years, 3 months ago by guohui

Modified:
6 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

Merge: Show search box on settings page in ChromeOS guest mode. BUG=408030 R=estade@chromium.org TEST=In ChromeOS: Open a guest. Go to settings. Verify search box there. On desktop: Open a guest. Go to settings. Verify search box not there. TBR=mlerman@chromium.org Review URL: https://codereview.chromium.org/517633002 Cr-Commit-Position: refs/heads/master@{#292935} (cherry picked from commit 5aa9a79b95b20ff23a41dbe2eba0da0d4a10c1cc) Committed: https://chromium.googlesource.com/chromium/src/+/927fde1f4b7a71fbe8bed8143ece21d376be4691

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/browser/resources/options/browser_options.css	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

guohui

6 years, 3 months ago (2014-09-03 18:41:07 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 927fde1 (presubmit successful).