Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517633002: Show search box on settings page in ChromeOS guest mode. (Closed)

Created:
6 years, 3 months ago by Mike Lerman
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Show search box on settings page in ChromeOS guest mode. BUG=408030 R=estade@chromium.org TEST=In ChromeOS: Open a guest. Go to settings. Verify search box there. On desktop: Open a guest. Go to settings. Verify search box not there. Committed: https://crrev.com/5aa9a79b95b20ff23a41dbe2eba0da0d4a10c1cc Cr-Commit-Position: refs/heads/master@{#292935}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use -webkit-any #

Total comments: 1

Patch Set 3 : estade nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/resources/options/browser_options.css View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Mike Lerman
Hi Evan, Another small review for you. Thanks!
6 years, 3 months ago (2014-08-28 15:37:02 UTC) #1
Evan Stade
https://codereview.chromium.org/517633002/diff/1/chrome/browser/resources/options/browser_options.css File chrome/browser/resources/options/browser_options.css (right): https://codereview.chromium.org/517633002/diff/1/chrome/browser/resources/options/browser_options.css#newcode456 chrome/browser/resources/options/browser_options.css:456: div[guestmode=true] #startup-section, this looks like a job for -webkit-any
6 years, 3 months ago (2014-08-28 18:11:22 UTC) #2
Mike Lerman
https://codereview.chromium.org/517633002/diff/1/chrome/browser/resources/options/browser_options.css File chrome/browser/resources/options/browser_options.css (right): https://codereview.chromium.org/517633002/diff/1/chrome/browser/resources/options/browser_options.css#newcode456 chrome/browser/resources/options/browser_options.css:456: div[guestmode=true] #startup-section, On 2014/08/28 18:11:22, Evan Stade wrote: > ...
6 years, 3 months ago (2014-08-29 19:21:07 UTC) #3
Evan Stade
lgtm https://codereview.chromium.org/517633002/diff/20001/chrome/browser/resources/options/browser_options.css File chrome/browser/resources/options/browser_options.css (right): https://codereview.chromium.org/517633002/diff/20001/chrome/browser/resources/options/browser_options.css#newcode462 chrome/browser/resources/options/browser_options.css:462: #appearance-section, #startup-section, #reset-profile-settings-section) { nit: I would format ...
6 years, 3 months ago (2014-08-29 19:44:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/517633002/40001
6 years, 3 months ago (2014-09-02 14:43:23 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b1ba354b0a3ad1f034064be12cdaf4b717cabafa
6 years, 3 months ago (2014-09-02 15:49:12 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:46 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5aa9a79b95b20ff23a41dbe2eba0da0d4a10c1cc
Cr-Commit-Position: refs/heads/master@{#292935}

Powered by Google App Engine
This is Rietveld 408576698