content/browser/media/android/browser_media_player_manager.h - Issue 534063002: Remove OnMediaResourcesReleased callback passed to MediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/browser_media_player_manager.h

Issue 534063002: Remove OnMediaResourcesReleased callback passed to MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/media/android/browser_media_player_manager.cc » ('j') | content/browser/media/android/browser_media_player_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/android/browser_media_player_manager.h

diff --git a/content/browser/media/android/browser_media_player_manager.h b/content/browser/media/android/browser_media_player_manager.h

index 5f3fae57565fa377082a5ecc370b690742f62377..0332fc148203e28039a5f712134fbc3c8359d715 100644

--- a/content/browser/media/android/browser_media_player_manager.h

+++ b/content/browser/media/android/browser_media_player_manager.h

@@ -158,8 +158,7 @@ class CONTENT_EXPORT BrowserMediaPlayerManager

// constrained by hardware and memory limits.

virtual void OnMediaResourcesRequested(int player_id);

- // Similar to the above call, MediaPlayerAndroid must call this method when

- // releasing all the decoding resources.

+ // Called when a player releases all decoding resources.

virtual void OnMediaResourcesReleased(int player_id);

xhwang 2014/09/03 16:36:58 Please update the CL description/title: "Remove B

xhwang 2014/09/03 16:36:58 nit: This is not a callback anymore. How about "Re

qinmin 2014/09/03 18:27:52 Done.

#if defined(VIDEO_HOLE)