Remove OnMediaResourcesReleased callback passed to MediaPlayerAndroid

content/browser/media/android/browser_media_player_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_
 #define CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 140 matching lines @@
       media::MediaPlayerManager* manager,
       BrowserDemuxerAndroid* demuxer);
 
   // MediaPlayerAndroid must call this before it is going to decode
   // media streams. This helps the manager object maintain an array
   // of active MediaPlayerAndroid objects and release the resources
   // when needed. Currently we only count video resources as they are
   // constrained by hardware and memory limits.
   virtual void OnMediaResourcesRequested(int player_id);
 
-  // Similar to the above call, MediaPlayerAndroid must call this method when
-  // releasing all the decoding resources.
+  // Called when a player releases all decoding resources.
   virtual void OnMediaResourcesReleased(int player_id);

[xhwang, 2014/09/03 16:36:58]

Please update the CL description/title:

"Remove BrowserMediaPlayerManager::OnMediaResourcesReleased()"

You are not really removing this call :) Instead, you are removing the
ReleaseMediaResourcesCB in MediaPlayerAndroid ctor.

[xhwang, 2014/09/03 16:36:58]

nit: This is not a callback anymore. How about
"ReleaseMediaResources(player_id)"?

[qinmin, 2014/09/03 18:27:52]

Done.

[qinmin, 2014/09/03 18:27:52]

Done.

 
 #if defined(VIDEO_HOLE)
   void OnRequestExternalSurface(int player_id, const gfx::RectF& rect);
 #endif  // defined(VIDEO_HOLE)
 
   RenderFrameHost* const render_frame_host_;
 
   // An array of managed players.
   ScopedVector<media::MediaPlayerAndroid> players_;
 
@@ skipping 18 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<BrowserMediaPlayerManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserMediaPlayerManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_