Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 533993002: Roll gyp r1970:1972 (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll gyp r1970:1972 r1972: Makes matching of build files work when absolute Matching wasn't working if paths supplied were absolute. r1971: Support for custom NM/readelf binaries in your toolchain. BUG=109173 TEST=none R=scottmg@chromium.org Committed: https://crrev.com/6e1f2a87f0d559847e1dd192f0ff318950f2eb94 Cr-Commit-Position: refs/heads/master@{#293041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
6 years, 3 months ago (2014-09-02 22:18:23 UTC) #1
scottmg
lgtm
6 years, 3 months ago (2014-09-02 22:22:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/533993002/1
6 years, 3 months ago (2014-09-02 22:30:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0ba4bf5582206f4d55618cd1035a81fdf7b91e4f
6 years, 3 months ago (2014-09-03 01:31:38 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e1f2a87f0d559847e1dd192f0ff318950f2eb94
Cr-Commit-Position: refs/heads/master@{#293041}

Powered by Google App Engine
This is Rietveld 408576698