Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 53383002: ChromeOS: Remove ProfileHelper::IsSigninProfile. (Closed)

Created:
7 years, 1 month ago by pneubeck (no reviews)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

ChromeOS: Remove ProfileHelper::IsSigninProfile. Since Profile::IsLoginProfile() was added, ProfileHelper::IsSigninProfile is redundant and can be removed. With this commit, ProfileImpl::is_login_profile_ is initialized already in the initializer list, so that IsLoginProfile / is_login_profile_ always return the correct value. BUG=312660

Patch Set 1 #

Patch Set 2 : Fix TestingProfile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pneubeck (no reviews)
@Mitsuru, FYI @David, you reviewed the addition of Profile::IsLoginProfile, please also take a look at ...
7 years, 1 month ago (2013-10-30 21:02:52 UTC) #1
Nikita (slow)
lgtm
7 years, 1 month ago (2013-10-30 21:36:02 UTC) #2
pneubeck (no reviews)
7 years, 1 month ago (2013-10-31 15:12:11 UTC) #3
Ok. After trying to fix all the other profiles like OffTheRecordProfile and
FakeProfile, I come to the conclusion that Profile::IsLoginProfile doesn't have
any advantage compared to ProfileHelper::IsSigninProfile but leads to a lot of
code duplication and GetPath is easily out of sync to IsLoginProfile.

Thus, instead I set up a CL to remove IsLoginProfile again:
https://codereview.chromium.org/47923016

Powered by Google App Engine
This is Rietveld 408576698