Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 47923016: ChromeOS: Remove Profile::IsLoginProfile. (Closed)

Created:
7 years, 1 month ago by pneubeck (no reviews)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

ChromeOS: Remove Profile::IsLoginProfile. IsLoginProfile is based on ProfileHelper::IsSigninProfile. There is no obvious/good reason why IsLoginProfile is additionally required. Even worse, IsLoginProfile is implemented by every subclass of Profile and is inconsistent to ProfileHelper::IsSigninProfile and to Profile::GetPath(). BUG=312660 (For Fake-/TestingProfile) R=davemoore@google.com, nkostylev@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233263

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 4 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pneubeck (no reviews)
@Mitsuru, FYI @David, you reviewed the addition of Profile::IsLoginProfile, please also take a look at ...
7 years, 1 month ago (2013-10-31 18:48:03 UTC) #1
pneubeck (no reviews)
On 2013/10/31 18:48:03, pneubeck wrote: > @Mitsuru, FYI > > @David, you reviewed the addition ...
7 years, 1 month ago (2013-11-05 11:56:52 UTC) #2
davemoore (google)
lgtm
7 years, 1 month ago (2013-11-05 17:51:35 UTC) #3
pneubeck (no reviews)
On 2013/11/05 17:51:35, davemoore (google) wrote: > lgtm I think this was from the wrong ...
7 years, 1 month ago (2013-11-05 18:10:41 UTC) #4
Nikita (slow)
lgtm, thanks for the cleanup!
7 years, 1 month ago (2013-11-05 18:15:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/47923016/1
7 years, 1 month ago (2013-11-05 20:05:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185402
7 years, 1 month ago (2013-11-05 22:15:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/47923016/1
7 years, 1 month ago (2013-11-05 22:40:55 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220076
7 years, 1 month ago (2013-11-06 00:52:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/47923016/1
7 years, 1 month ago (2013-11-06 09:28:32 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220494
7 years, 1 month ago (2013-11-06 13:11:59 UTC) #11
pneubeck (no reviews)
7 years, 1 month ago (2013-11-06 13:25:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r233263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698