Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 533813002: [Android] Fix overflow menu enter tablet animation (Closed)

Created:
6 years, 3 months ago by David Trainor- moved to gerrit
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

[Android] Fix overflow menu enter tablet animation - On tablets the new anchor point was 6dp off due to the new shadow assets. To fix this add a 6dp translate to the enter animation that will move the asset into the correct location as the scale animation runs. This effectively mimics the old animation but allows the offset to be included. BUG=405352 Review URL: https://codereview.chromium.org/488863002 Cr-Commit-Position: refs/heads/master@{#290773} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290773 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 6f2a9c8524cf5a0e92bffeb63550be0321bacfbb) Committed: https://chromium.googlesource.com/chromium/src/+/b1838a4e4c2d0a1b9ca78d3f40ee33bcbf0670b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/android/java/res/anim/menu_enter.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/res/values-sw600dp/dimens.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
David Trainor- moved to gerrit
6 years, 3 months ago (2014-09-02 19:00:08 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b1838a4.

Powered by Google App Engine
This is Rietveld 408576698