Issue 488863002: [Android] Fix overflow menu enter tablet animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 488863002: [Android] Fix overflow menu enter tablet animation (Closed)

Created:
6 years, 4 months ago by David Trainor- moved to gerrit

Modified:
6 years, 4 months ago

Reviewers:
aurimas (slooooooooow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Fix overflow menu enter tablet animation - On tablets the new anchor point was 6dp off due to the new shadow assets. To fix this add a 6dp translate to the enter animation that will move the asset into the correct location as the scale animation runs. This effectively mimics the old animation but allows the offset to be included. BUG=405352 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290773

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -6 lines)			Patch
M	chrome/android/java/res/anim/menu_enter.xml	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/android/java/res/values-sw600dp/dimens.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/java/res/values/dimens.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

David Trainor- moved to gerrit

The CQ bit was checked by dtrainor@chromium.org

6 years, 4 months ago (2014-08-20 00:33:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/488863002/1

6 years, 4 months ago (2014-08-20 00:34:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290773

Expand Messages | Collapse Messages