Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 533743004: Fix Chrome linker errors in GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/83fd424ef7bcba7af879bad8cd62bf708e6f5947 Cr-Commit-Position: refs/heads/master@{#292978}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -123 lines) Patch
M chrome/browser/BUILD.gn View 1 5 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/BUILD.gn View 1 1 chunk +0 lines, -76 lines 0 comments Download
M content/browser/BUILD.gn View 1 3 chunks +6 lines, -8 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 3 chunks +17 lines, -0 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/BUILD.gn View 1 3 chunks +6 lines, -3 lines 0 comments Download
M remoting/client/BUILD.gn View 1 2 chunks +1 line, -3 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/BUILD.gn View 1 1 chunk +4 lines, -11 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-09-02 19:13:05 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-02 19:35:42 UTC) #3
brettw
Committed patchset #3 (id:40001) to pending queue manually as efaebbc.
6 years, 3 months ago (2014-09-02 19:48:52 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:20:09 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/83fd424ef7bcba7af879bad8cd62bf708e6f5947
Cr-Commit-Position: refs/heads/master@{#292978}

Powered by Google App Engine
This is Rietveld 408576698