chrome/common/BUILD.gn - Issue 533743004: Fix Chrome linker errors in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 533743004: Fix Chrome linker errors in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index 45710c00b9963e336b162b129288f8a5c8995dbf..34e3ef21d59e8beb85272caa871717b28ba62073 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -211,11 +211,15 @@ static_library("common") {

deps += [ "//remoting/client/plugin" ]

}

if (enable_plugins) {

+ sources += [

+ "pepper_flash.cc",

+ "pepper_flash.h",

+ "pepper_permission_util.cc",

+ "pepper_permission_util.h",

+ ]

deps += [

"//third_party/adobe/flash:flapper_version_h",

]

- } else {

- sources -= [ "pepper_permission_util.cc" ]

}

if (!enable_webrtc) {

sources -= [ "media/webrtc_logging_messages.h" ]

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »