Issue 533663002: [Sync] Fix a crash when sign into sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 533663002: [Sync] Fix a crash when sign into sync. (Closed)

Created:
6 years, 3 months ago by Mathieu

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

[Sync] Fix a crash when sign into sync. The crash was caused by a dangling pointer to a deleted observer registered by MostVisitedSites. BUG=406996 Review URL: https://codereview.chromium.org/501973004 Cr-Commit-Position: refs/heads/master@{#292034} (cherry picked from commit 94a4210d30dfa1201a818dc76d6a7afda1baf47d) Committed: https://chromium.googlesource.com/chromium/src/+/59533eac8929d7f32954958078e7cfe60df314b4

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/android/most_visited_sites.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 59533ea.