Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 501973004: [Sync] Fix a crash when sign into sync. (Closed)

Created:
6 years, 3 months ago by Feng Qian
Modified:
6 years, 3 months ago
Reviewers:
Mathieu, Yaron, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix a crash when sign into sync. The crash was caused by a dangling pointer to a deleted observer registered by MostVisitedSites. BUG=406996 Committed: https://crrev.com/94a4210d30dfa1201a818dc76d6a7afda1baf47d Cr-Commit-Position: refs/heads/master@{#292034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/android/most_visited_sites.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Feng Qian
feng@chromium.org changed reviewers: + mathp@chromium.org, yfriedman@chromium.org
6 years, 3 months ago (2014-08-26 20:56:23 UTC) #1
Feng Qian
6 years, 3 months ago (2014-08-26 20:56:30 UTC) #2
Mathieu
lgtm, I'm so sorry :\
6 years, 3 months ago (2014-08-26 20:58:26 UTC) #3
Feng Qian
On 2014/08/26 20:58:26, Mathieu Perreault wrote: > lgtm, I'm so sorry :\ no problem. Yaron, ...
6 years, 3 months ago (2014-08-26 21:00:03 UTC) #4
Feng Qian
feng@chromium.org changed reviewers: + newt@chromium.org
6 years, 3 months ago (2014-08-26 21:12:26 UTC) #5
Feng Qian
6 years, 3 months ago (2014-08-26 21:12:26 UTC) #6
newt (away)
lgtm
6 years, 3 months ago (2014-08-26 21:32:36 UTC) #7
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 3 months ago (2014-08-26 21:33:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/501973004/1
6 years, 3 months ago (2014-08-26 21:35:25 UTC) #9
Yaron
lgtm
6 years, 3 months ago (2014-08-26 21:53:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (1) as 84c031ded14aaf5944fc2561ab5102fe5cd3534d
6 years, 3 months ago (2014-08-26 23:43:14 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:47:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94a4210d30dfa1201a818dc76d6a7afda1baf47d
Cr-Commit-Position: refs/heads/master@{#292034}

Powered by Google App Engine
This is Rietveld 408576698