Cleanup throwing of the RangeError in the runtime to remove duplicated code.

runtime/vm/exceptions.cc

Index: runtime/vm/exceptions.cc
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index 96b498482933e14e56d3cca176b40bcdcdeb0600..c7e0fa1afbff0372fa5bb1a8f1775f33b794d61d 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -667,6 +667,13 @@ void Exceptions::ThrowArgumentError(const Instance& arg) {
 }
 
 
+void Exceptions::ThrowRangeError(const Instance& arg) {
+  const Array& args = Array::Handle(Array::New(1));
+  args.SetAt(0, arg);
+  Exceptions::ThrowByType(Exceptions::kRange, args);

[Ivan Posva, 2014/09/02 15:27:07]

It would be helpful to give the expected range here as we do in other places in
the libraries. I do understand that this was not the case with most/all of the
code being refactored here, but I think it would be a nice improvement.

That means that you need to add two different ThrowRangeError functions here,
similar to the constructors of RangeError and additionally a private factory in
RangeError to distinguish them.

[Vyacheslav Egorov (Google), 2014/09/02 16:02:53]

Alternatively I can just format a string like we do in other places in the
libraries.

I will take a look at what can be done here.

On 2014/09/02 15:27:07, Ivan Posva wrote:

+}
+
+
 RawObject* Exceptions::Create(ExceptionType type, const Array& arguments) {
   Library& library = Library::Handle();
   const String* class_name = NULL;