Cleanup throwing of the RangeError in the runtime to remove duplicated code.

runtime/vm/exceptions.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/exceptions.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/flags.h"
@@ skipping 649 matching lines @@
 }
 
 
 void Exceptions::ThrowArgumentError(const Instance& arg) {
   const Array& args = Array::Handle(Array::New(1));
   args.SetAt(0, arg);
   Exceptions::ThrowByType(Exceptions::kArgument, args);
 }
 
 
+void Exceptions::ThrowRangeError(const Instance& arg) {
+  const Array& args = Array::Handle(Array::New(1));
+  args.SetAt(0, arg);
+  Exceptions::ThrowByType(Exceptions::kRange, args);

[Ivan Posva, 2014/09/02 15:27:07]

It would be helpful to give the expected range here as we do in other places in
the libraries. I do understand that this was not the case with most/all of the
code being refactored here, but I think it would be a nice improvement.

That means that you need to add two different ThrowRangeError functions here,
similar to the constructors of RangeError and additionally a private factory in
RangeError to distinguish them.

[Vyacheslav Egorov (Google), 2014/09/02 16:02:53]

Alternatively I can just format a string like we do in other places in the
libraries.

I will take a look at what can be done here.

On 2014/09/02 15:27:07, Ivan Posva wrote:

+}
+
+
 RawObject* Exceptions::Create(ExceptionType type, const Array& arguments) {
   Library& library = Library::Handle();
   const String* class_name = NULL;
   const String* constructor_name = &Symbols::Dot();
   switch (type) {
     case kNone:
     case kStackOverflow:
     case kOutOfMemory:
       UNREACHABLE();
       break;
@@ skipping 81 matching lines @@
 
 // Throw JavascriptCompatibilityError exception.
 void Exceptions::ThrowJavascriptCompatibilityError(const char* msg) {
   const Array& exc_args = Array::Handle(Array::New(1));
   const String& msg_str = String::Handle(String::New(msg));
   exc_args.SetAt(0, msg_str);
   Exceptions::ThrowByType(Exceptions::kJavascriptCompatibilityError, exc_args);
 }
 
 }  // namespace dart