Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 533383002: mac, fullscreen: Major refactor. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Major fullscreen refactor. This CL is the combination of https://codereview.chromium.org/493143004/ and https://codereview.chromium.org/523723002/. They were reviewed separately to make the review process easier. Full a more detailed explanation of the refactor, see http://crbug.com/406656 Bugs fixed: - Attempting to fullscreen HTML5 content with --enable-simplified-fullscreen caused UI problems. - Omnibox/toolbar did not slide in Canonical Fullscreen. - Presentation Mode and Canonical Fullscreen tab strip layout is incorrect when menubar is hidden. - Canonical Fullscreen should ignore the mouse tracking area. Refactor mostly consisted of: - Deleted FullscreenModeController. - External (outside of BWC) invocations of fullscreen mode are much simpler. - Significant code reduction and logic simplification in BWC. BUG=406656, 405561 TBR=rsesek Committed: https://crrev.com/cfca18fc3711760d3b1bcb50d0a3475509111126 Cr-Commit-Position: refs/heads/master@{#293238}

Patch Set 1 : Clone of patch set 7 from https://codereview.chromium.org/493143004/ #

Patch Set 2 : Clone of patch set 4 from https://codereview.chromium.org/523723002/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -669 lines) Patch
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 4 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +0 lines, -65 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 5 chunks +97 lines, -31 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 11 chunks +63 lines, -135 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 4 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 23 chunks +224 lines, -129 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 3 chunks +8 lines, -8 lines 0 comments Download
D chrome/browser/ui/cocoa/fullscreen_mode_controller.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/cocoa/fullscreen_mode_controller.mm View 1 chunk +0 lines, -173 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.h View 1 4 chunks +34 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 1 16 chunks +101 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
erikchen
6 years, 3 months ago (2014-09-03 21:01:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/533383002/40001
6 years, 3 months ago (2014-09-03 21:21:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 3a15eeac9bd620d5e0246fbc5d896bb5fcdea9c2
6 years, 3 months ago (2014-09-04 00:35:23 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cfca18fc3711760d3b1bcb50d0a3475509111126
Cr-Commit-Position: refs/heads/master@{#293238}

Powered by Google App Engine
This is Rietveld 408576698