chrome/browser/ui/cocoa/browser_window_controller_unittest.mm - Issue 533383002: mac, fullscreen: Major refactor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 533383002: mac, fullscreen: Major refactor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clone of patch set 4 from https://codereview.chromium.org/523723002/ Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/fullscreen_mode_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

index 6e97ed404d3e7822c687e9fa2aeec5711f2d2448..5840eed7234fdca29e851e7da94a8b43af466be1 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

@@ -831,15 +831,15 @@ void WaitForFullScreenTransition() {

// http://crbug.com/53586

TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestFullscreen) {

[controller_ showWindow:nil];

- EXPECT_FALSE([controller_ isFullscreen]);

+ EXPECT_FALSE([controller_ isInAnyFullscreenMode]);

- [controller_ enterFullscreen];

+ [controller_ enterFullscreenWithChrome];

WaitForFullScreenTransition();

- EXPECT_TRUE([controller_ isFullscreen]);

+ EXPECT_TRUE([controller_ isInAnyFullscreenMode]);

- [controller_ exitFullscreen];

+ [controller_ exitAnyFullscreen];

WaitForFullScreenTransition();

- EXPECT_FALSE([controller_ isFullscreen]);

+ EXPECT_FALSE([controller_ isInAnyFullscreenMode]);

}

// If this test fails, it is usually a sign that the bots have some sort of

@@ -850,12 +850,12 @@ TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestFullscreen) {

TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestActivate) {

[controller_ showWindow:nil];

- EXPECT_FALSE([controller_ isFullscreen]);

+ EXPECT_FALSE([controller_ isInAnyFullscreenMode]);

[controller_ activate];

EXPECT_TRUE(IsFrontWindow([controller_ window]));

- [controller_ enterFullscreen];

+ [controller_ enterFullscreenWithChrome];

WaitForFullScreenTransition();

[controller_ activate];

@@ -864,7 +864,7 @@ TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestActivate) {

EXPECT_TRUE(IsFrontWindow([controller_ createFullscreenWindow]));

// We have to cleanup after ourselves by unfullscreening.

- [controller_ exitFullscreen];

+ [controller_ exitAnyFullscreen];

WaitForFullScreenTransition();

}