[Android] Add uncategorized bookmark querying JNI bridge function.

[Android] Add uncategorized bookmark querying JNI bridge function.

In the new enhanced bookmark UI, Uncategorized items are bookmarks
under mobile and others node.

BUG=386785
Committed: https://crrev.com/e139d98e08a18d63dbe4bb0f5458e023a35b2404
Cr-Commit-Position: refs/heads/master@{#293336}

[Kibeom Kim (inactive), 2014-09-03 20:40:55]

kkimlabs@chromium.org changed reviewers:
+ ianwen@chromium.org, newt@chromium.org, tedchoc@chromium.org

[Ted C, 2014-09-03 20:49:06]

https://codereview.chromium.org/533363002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/533363002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:206:
public List<BookmarkId> getUncategorizedBookmarkIDs() {
javadoc plz

https://codereview.chromium.org/533363002/diff/1/chrome/browser/android/bookm...
File chrome/browser/android/bookmarks/bookmarks_bridge.cc (right):

https://codereview.chromium.org/533363002/diff/1/chrome/browser/android/bookm...
chrome/browser/android/bookmarks/bookmarks_bridge.cc:272:
Java_BookmarksBridge_addToBookmarkIdList(env,
why not add them in the above loops instead of creating a vector?

[Kibeom Kim (inactive), 2014-09-03 20:54:24]

https://codereview.chromium.org/533363002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/533363002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:206:
public List<BookmarkId> getUncategorizedBookmarkIDs() {
On 2014/09/03 20:49:06, Ted C wrote:
> javadoc plz

Done.

https://codereview.chromium.org/533363002/diff/1/chrome/browser/android/bookm...
File chrome/browser/android/bookmarks/bookmarks_bridge.cc (right):

https://codereview.chromium.org/533363002/diff/1/chrome/browser/android/bookm...
chrome/browser/android/bookmarks/bookmarks_bridge.cc:272:
Java_BookmarksBridge_addToBookmarkIdList(env,
On 2014/09/03 20:49:06, Ted C wrote:
> why not add them in the above loops instead of creating a vector?

Done.

[Ted C, 2014-09-03 20:56:44]

lgtm w/ two nits

https://codereview.chromium.org/533363002/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/533363002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:207: *
@return The uncategorized bookmark IDs. They are sub-bookmarks of mobile and
other folders.
I would probably say "direct descendant" instead of "sub-" to be clear that it
will not further traverse the child folders.

https://codereview.chromium.org/533363002/diff/20001/chrome/browser/android/b...
File chrome/browser/android/bookmarks/bookmarks_bridge.cc (right):

https://codereview.chromium.org/533363002/diff/20001/chrome/browser/android/b...
chrome/browser/android/bookmarks/bookmarks_bridge.cc:251: std::vector<const
BookmarkNode*> uncategorized_bookmarks;
remove

[Kibeom Kim (inactive), 2014-09-03 21:00:19]

https://codereview.chromium.org/533363002/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/533363002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:207: *
@return The uncategorized bookmark IDs. They are sub-bookmarks of mobile and
other folders.
On 2014/09/03 20:56:44, Ted C wrote:
> I would probably say "direct descendant" instead of "sub-" to be clear that it
> will not further traverse the child folders.

Done.

https://codereview.chromium.org/533363002/diff/20001/chrome/browser/android/b...
File chrome/browser/android/bookmarks/bookmarks_bridge.cc (right):

https://codereview.chromium.org/533363002/diff/20001/chrome/browser/android/b...
chrome/browser/android/bookmarks/bookmarks_bridge.cc:251: std::vector<const
BookmarkNode*> uncategorized_bookmarks;
On 2014/09/03 20:56:44, Ted C wrote:
> remove

Done.

[Kibeom Kim (inactive), 2014-09-04 17:00:30]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-09-04 17:02:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/533363002/40001

[commit-bot: I haz the power, 2014-09-04 21:09:58]

Committed patchset #3 (id:40001) as 1d5011f13225cd7c560c324829f228b4fda85da6

[commit-bot: I haz the power, 2014-09-10 03:32:40]

Patchset 3 (id:??) landed as
https://crrev.com/e139d98e08a18d63dbe4bb0f5458e023a35b2404
Cr-Commit-Position: refs/heads/master@{#293336}