Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 533363002: [Android] Add uncategorized bookmark querying JNI bridge function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stars-top-level-brdige
Patch Set: java doc, removed vector Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h" 5 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/containers/stack_container.h" 8 #include "base/containers/stack_container.h"
9 #include "base/i18n/string_compare.h" 9 #include "base/i18n/string_compare.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 238
239 for (std::vector<const BookmarkNode*>::const_iterator it = 239 for (std::vector<const BookmarkNode*>::const_iterator it =
240 top_level_folders.begin(); it != top_level_folders.end(); ++it) { 240 top_level_folders.begin(); it != top_level_folders.end(); ++it) {
241 Java_BookmarksBridge_addToBookmarkIdList(env, 241 Java_BookmarksBridge_addToBookmarkIdList(env,
242 j_result_obj, 242 j_result_obj,
243 (*it)->id(), 243 (*it)->id(),
244 GetBookmarkType(*it)); 244 GetBookmarkType(*it));
245 } 245 }
246 } 246 }
247 247
248 void BookmarksBridge::GetUncategorizedBookmarkIDs(JNIEnv* env,
249 jobject obj,
250 jobject j_result_obj) {
251 std::vector<const BookmarkNode*> uncategorized_bookmarks;
Ted C 2014/09/03 20:56:44 remove
Kibeom Kim (inactive) 2014/09/03 21:00:19 Done.
252
253 const BookmarkNode* mobile_node = bookmark_model_->mobile_node();
254 for (int i = 0; i < mobile_node->child_count(); ++i) {
255 const BookmarkNode* node = mobile_node->GetChild(i);
256 if (!node->is_folder()) {
257 Java_BookmarksBridge_addToBookmarkIdList(env,
258 j_result_obj,
259 node->id(),
260 GetBookmarkType(node));
261 }
262 }
263
264 const BookmarkNode* other_node = bookmark_model_->other_node();
265 for (int i = 0; i < other_node->child_count(); ++i) {
266 const BookmarkNode* node = other_node->GetChild(i);
267 if (!node->is_folder()) {
268 Java_BookmarksBridge_addToBookmarkIdList(env,
269 j_result_obj,
270 node->id(),
271 GetBookmarkType(node));
272 }
273 }
274 }
275
248 void BookmarksBridge::GetChildIDs(JNIEnv* env, 276 void BookmarksBridge::GetChildIDs(JNIEnv* env,
249 jobject obj, 277 jobject obj,
250 jlong id, 278 jlong id,
251 jint type, 279 jint type,
252 jboolean get_folders, 280 jboolean get_folders,
253 jboolean get_bookmarks, 281 jboolean get_bookmarks,
254 jobject j_result_obj) { 282 jobject j_result_obj) {
255 DCHECK(IsLoaded()); 283 DCHECK(IsLoaded());
256 284
257 const BookmarkNode* parent = GetNodeByID(id, type); 285 const BookmarkNode* parent = GetNodeByID(id, type);
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 BookmarkModelChanged(); 781 BookmarkModelChanged();
754 } 782 }
755 783
756 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) { 784 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) {
757 NotifyIfDoneLoading(); 785 NotifyIfDoneLoading();
758 } 786 }
759 787
760 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) { 788 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) {
761 partner_bookmarks_shim_ = NULL; 789 partner_bookmarks_shim_ = NULL;
762 } 790 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698