Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 533343002: Add reference base class to GrGpuResource with pending IO references. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add reference base class to GrGpuResourcewith pending IO references. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/00b76bd750e668a6989dd497313e715d1b476fdc

Patch Set 1 #

Patch Set 2 : move ~ to cpp and fix comment #

Total comments: 2

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -15 lines) Patch
M include/gpu/GrGpuResource.h View 1 2 2 chunks +95 lines, -13 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
6 years, 3 months ago (2014-09-03 20:24:09 UTC) #2
robertphillips
lgtm + a question https://codereview.chromium.org/533343002/diff/20001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/533343002/diff/20001/include/gpu/GrGpuResource.h#newcode23 include/gpu/GrGpuResource.h:23: * GrGpuResource. Is here the ...
6 years, 3 months ago (2014-09-03 20:29:30 UTC) #3
bsalomon
https://codereview.chromium.org/533343002/diff/20001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/533343002/diff/20001/include/gpu/GrGpuResource.h#newcode23 include/gpu/GrGpuResource.h:23: * GrGpuResource. On 2014/09/03 20:29:30, robertphillips wrote: > Is ...
6 years, 3 months ago (2014-09-03 20:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/533343002/40001
6 years, 3 months ago (2014-09-03 20:49:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 21:05:57 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 00b76bd750e668a6989dd497313e715d1b476fdc

Powered by Google App Engine
This is Rietveld 408576698