Fix typed lowering of JSToBoolean on number inputs.

Fix typed lowering of JSToBoolean on number inputs.

R=titzer@chromium.org
TEST=cctest/test-js-typed-lowering/JSToBoolean_replacement

Committed: https://code.google.com/p/v8/source/detail?r=23642

[titzer, 2014-09-03 09:59:16]

Can I get a TODO(titzer) in the test file to test this case?

[Michael Starzinger, 2014-09-03 11:21:34]

Nope, but you can get the test. :)

[titzer, 2014-09-03 11:24:49]

lgtm with comment

https://codereview.chromium.org/533103002/diff/20001/test/cctest/compiler/tes...
File test/cctest/compiler/test-js-typed-lowering.cc (right):

https://codereview.chromium.org/533103002/diff/20001/test/cctest/compiler/tes...
test/cctest/compiler/test-js-typed-lowering.cc:526:
CHECK_EQ(IrOpcode::kBooleanNot, r->opcode());
Check it's actually BooleanNot(NumberEqual(x, 0))

?

[Michael Starzinger, 2014-09-03 11:33:00]

https://codereview.chromium.org/533103002/diff/20001/test/cctest/compiler/tes...
File test/cctest/compiler/test-js-typed-lowering.cc (right):

https://codereview.chromium.org/533103002/diff/20001/test/cctest/compiler/tes...
test/cctest/compiler/test-js-typed-lowering.cc:526:
CHECK_EQ(IrOpcode::kBooleanNot, r->opcode());
On 2014/09/03 11:24:49, titzer wrote:
> Check it's actually BooleanNot(NumberEqual(x, 0))
> 
> ?

As discussed offline: This is already checked in the above test case, see line
479 above. So we'll leave it as it is.

[Michael Starzinger, 2014-09-03 11:35:29]

Committed patchset #2 (id:20001) manually as 23642 (presubmit successful).