Fix typed lowering of JSToBoolean on number inputs.

test/cctest/compiler/test-js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/compiler/graph-inl.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/node-properties-inl.h"
@@ skipping 488 matching lines @@
   {  // ToBoolean(object)
     Node* r = R.ReduceUnop(op, Type::Object());
     CHECK_EQ(IrOpcode::kJSToBoolean, r->opcode());
   }
 }
 
 
 TEST(JSToBoolean_replacement) {
   JSTypedLoweringTester R;
 
-  Type* types[] = {Type::Null(), Type::Undefined(), Type::Boolean(),
+  Type* types[] = {Type::Null(),             Type::Undefined(),
+                   Type::Boolean(),          Type::Number(),
                    Type::DetectableObject(), Type::Undetectable()};
 
   for (size_t i = 0; i < arraysize(types); i++) {
     Node* n = R.Parameter(types[i]);
     Node* c = R.graph.NewNode(R.javascript.ToBoolean(), n, R.context(),
                               R.start(), R.start());
     Node* effect_use = R.UseForEffect(c);
     Node* add = R.graph.NewNode(R.simplified.ReferenceEqual(Type::Any()), n, c);
 
     R.CheckEffectInput(c, effect_use);
     Node* r = R.reduce(c);
 
     if (types[i]->Is(Type::Boolean())) {
       CHECK_EQ(n, r);
+    } else if (types[i]->Is(Type::Number())) {
+      CHECK_EQ(IrOpcode::kBooleanNot, r->opcode());

[titzer, 2014/09/03 11:24:49]

Check it's actually BooleanNot(NumberEqual(x, 0))

?

[Michael Starzinger, 2014/09/03 11:33:00]

As discussed offline: This is already checked in the above test case, see line
479 above. So we'll leave it as it is.

     } else {
       CHECK_EQ(IrOpcode::kHeapConstant, r->opcode());
     }
 
     CHECK_EQ(n, add->InputAt(0));
     CHECK_EQ(r, add->InputAt(1));
     R.CheckEffectInput(R.start(), effect_use);
   }
 }
 
@@ skipping 806 matching lines @@
           CHECK_EQ(p1, r->InputAt(0));
           CHECK_EQ(p0, r->InputAt(1));
         } else {
           CHECK_EQ(p0, r->InputAt(0));
           CHECK_EQ(p1, r->InputAt(1));
         }
       }
     }
   }
 }