Issue 532913002: Enable linking Chrome in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 532913002: Enable linking Chrome in the GN build. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@jingle

Project:
chromium

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/BUILD.gn	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

awong

LGTM YAY! On Tue, Sep 2, 2014 at 4:27 PM, <brettw@chromium.org> wrote: > Committed patchset ...

6 years, 3 months ago (2014-09-03 15:50:23 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:21:51 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/104c3d64b824932abc1981719820cd661da14a09
Cr-Commit-Position: refs/heads/master@{#293021}