chrome/BUILD.gn - Issue 532913002: Enable linking Chrome in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 532913002: Enable linking Chrome in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jingle

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index dc1444eb4e9a7347d28519635083468dbb2d734f..757a8ca75239d355964acf0577dbcc756d9698db 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -8,8 +8,7 @@ import("//chrome/version.gni")

# TODO(GYP) for Windows need to the the reorder-imports step which probably

# means adding another target and renaming this to chrome_initial like in GYP.

-#executable("chrome") { # TODO(GYP) enable once this links.

-source_set("chrome") {

+executable("chrome") {

# Because the sources list varies so significantly per-platform, generally

# each platform lists its own files rather than relying on filtering or

# removing unused files.

« no previous file with comments | « no previous file | no next file » | no next file with comments »