content/ fixups for scoped_refptr operator T* removal.

content/ fixups for scoped_refptr operator T* removal.

BUG=110610
TBR=sky@chromium.org

Committed: https://crrev.com/d3c60604e97ef9b681ad539ceffa601c0da62188
Cr-Commit-Position: refs/heads/master@{#293159}

[dcheng, 2014-09-02 23:53:41]

dcheng@chromium.org changed reviewers:
+ avi@chromium.org, raymes@chromium.org

[dcheng, 2014-09-02 23:53:42]

Manual fixups + additional fixups for code added since the first time I ran the
automated tool.

+avi for the overall review, +raymes for the one pepper change
(ppb_var_deprecated_impl.cc)

https://codereview.chromium.org/532833003/diff/1/content/renderer/pepper/ppb_...
File content/renderer/pepper/ppb_var_deprecated_impl.cc (right):

https://codereview.chromium.org/532833003/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:43: :
object_var_(V8ObjectVar::FromPPVar(var).get()),
Note: I'm not sure if this is safe or not. I've cced raymes@chromium.org to
review this particular line--usually, fields should probably be a scoped_refptr,
unless there's something that guarantees that ObjectAccessor will outlive the
V8ObjectVar.

[Avi (use Gerrit), 2014-09-02 23:55:53]

I have no comment on that V8 part. I thought that this was a straight-up
mechanical conversion to the equivalent. Are you saying that you're not sure the
current code is correct?

(LGTM)

[dcheng, 2014-09-02 23:59:39]

On 2014/09/02 at 23:55:53, avi wrote:
> I have no comment on that V8 part. I thought that this was a straight-up
mechanical conversion to the equivalent. Are you saying that you're not sure the
current code is correct?
> 
> (LGTM)

It might be completely correct. Or it might be one of those cases where it's
correct 99% of the time and it might result in a UaF the last 1% of the time.
I'd just like to make sure that it's intentional that the object isn't being
ref'ed.

[raymes, 2014-09-03 00:02:25]

https://codereview.chromium.org/532833003/diff/1/content/renderer/pepper/ppb_...
File content/renderer/pepper/ppb_var_deprecated_impl.cc (right):

https://codereview.chromium.org/532833003/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:43: :
object_var_(V8ObjectVar::FromPPVar(var).get()),
This is safe. You might hit a conflict because this change got reverted again.
Sorry :(

[dcheng, 2014-09-03 00:04:20]

https://codereview.chromium.org/532833003/diff/1/content/renderer/pepper/ppb_...
File content/renderer/pepper/ppb_var_deprecated_impl.cc (right):

https://codereview.chromium.org/532833003/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:43: :
object_var_(V8ObjectVar::FromPPVar(var).get()),
On 2014/09/03 00:02:25, raymes wrote:
> This is safe. You might hit a conflict because this change got reverted again.
> Sorry :(

Ha. OK, thanks. I'll pre-emptively revert this change.

[dcheng, 2014-09-03 00:05:45]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-09-03 00:07:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/532833003/20001

[commit-bot: I haz the power, 2014-09-03 01:32:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/54638)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dcheng, 2014-09-03 16:11:20]

dcheng@chromium.org changed reviewers:
+ sky@chromium.org

[dcheng, 2014-09-03 16:11:50]

TBRing sky for the one line change I had to make in chrome/ to fix the compile.

[dcheng, 2014-09-03 16:11:55]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-09-03 16:14:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/532833003/40001

[commit-bot: I haz the power, 2014-09-03 17:17:03]

Committed patchset #3 (id:40001) as 859c28657b270ce2f3defd5d7d311538a6604f5d

[commit-bot: I haz the power, 2014-09-10 03:26:29]

Patchset 3 (id:??) landed as
https://crrev.com/d3c60604e97ef9b681ad539ceffa601c0da62188
Cr-Commit-Position: refs/heads/master@{#293159}