content/ fixups for scoped_refptr operator T* removal.

content/renderer/pepper/ppb_var_deprecated_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/ppb_var_deprecated_impl.h"
 
 #include <limits>
 
 #include "content/renderer/pepper/host_globals.h"
 #include "content/renderer/pepper/message_channel.h"
@@ skipping 22 matching lines @@
 
 namespace {
 
 const char kInvalidIdentifierException[] = "Error: Invalid identifier.";
 const char kInvalidObjectException[] = "Error: Invalid object";
 const char kUnableToCallMethodException[] = "Error: Unable to call method";
 
 class ObjectAccessor {
  public:
   ObjectAccessor(PP_Var var)
-      : object_var_(V8ObjectVar::FromPPVar(var)),
+      : object_var_(V8ObjectVar::FromPPVar(var).get()),

[dcheng, 2014/09/02 23:53:41]

Note: I'm not sure if this is safe or not. I've cced raymes@chromium.org to
review this particular line--usually, fields should probably be a scoped_refptr,
unless there's something that guarantees that ObjectAccessor will outlive the
V8ObjectVar.

[raymes, 2014/09/03 00:02:25]

This is safe. You might hit a conflict because this change got reverted again.
Sorry :(

[dcheng, 2014/09/03 00:04:20]

Ha. OK, thanks. I'll pre-emptively revert this change.

         instance_(object_var_ ? object_var_->instance() : NULL) {
   }
 
   // Check if the object is valid. If it isn't, set an exception and return
   // false.
   bool IsValid(PP_Var* exception) {
     // If we already have an exception, then the call is invalid according to
     // the unittests.
     if (exception && exception->type != PP_VARTYPE_UNDEFINED)
       return false;
@@ skipping 288 matching lines @@
       &CallDeprecated,
       &Construct,
       &IsInstanceOfDeprecated,
       &CreateObjectDeprecated,
       &CreateObjectWithModuleDeprecated, };
 
   return &var_deprecated_interface;
 }
 
 }  // namespace content