chrome/browser/extensions/api/declarative_content/content_rules_registry.h - Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_rules_registry.h

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache

Patch Set: Updated Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/test_rules_registry.cc ('k') | chrome/browser/extensions/api/declarative_content/content_rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_rules_registry.h

diff --git a/chrome/browser/extensions/api/declarative_content/content_rules_registry.h b/chrome/browser/extensions/api/declarative_content/content_rules_registry.h

index 38e8cc01d6c3eb7bb28524f85b49d6aaed5b9f04..c3f62f2f3bfbb5b33d2e6b49f0d1212c1735c7e4 100644

--- a/chrome/browser/extensions/api/declarative_content/content_rules_registry.h

+++ b/chrome/browser/extensions/api/declarative_content/content_rules_registry.h

@@ -64,8 +64,7 @@ class ContentRulesRegistry : public RulesRegistry,

public:

// For testing, |ui_part| can be NULL. In that case it constructs the

// registry with storage functionality suspended.

- ContentRulesRegistry(Profile* profile,

- scoped_ptr<RulesCacheDelegate>* ui_part);

+ ContentRulesRegistry(Profile* profile, RulesCacheDelegate* cache_delegate);

// Applies all content rules given an update (CSS match change or

// page navigation, for now) from the renderer.

@@ -121,8 +120,6 @@ class ContentRulesRegistry : public RulesRegistry,

typedef std::map<ContentRule::GlobalRuleId, linked_ptr<ContentRule> >

RulesMap;

- Profile* const profile_;

// Map that tells us which ContentRules may match under the condition that

// the URLMatcherConditionSet::ID was returned by the |url_matcher_|.

URLMatcherIdToRule match_id_to_rule_;