chrome/browser/extensions/api/declarative/test_rules_registry.cc - Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/test_rules_registry.cc

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache

Patch Set: Updated Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/test_rules_registry.h ('k') | chrome/browser/extensions/api/declarative_content/content_rules_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/test_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative/test_rules_registry.cc b/chrome/browser/extensions/api/declarative/test_rules_registry.cc

index 96858e302313ac87f1ced04ce3627534d0afbe17..d22ce15b18a0034f28dd138163fca131a65ecdff 100644

--- a/chrome/browser/extensions/api/declarative/test_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative/test_rules_registry.cc

@@ -13,19 +13,17 @@ TestRulesRegistry::TestRulesRegistry(content::BrowserThread::ID owner_thread,

: RulesRegistry(NULL /*profile*/,

event_name,

owner_thread,

- false /*log_storage_init_delay, this is ignored*/,

- NULL /*ui_part*/) {}

+ NULL) {}

TestRulesRegistry::TestRulesRegistry(

Profile* profile,

const std::string& event_name,

content::BrowserThread::ID owner_thread,

- scoped_ptr<RulesCacheDelegate>* ui_part)

+ RulesCacheDelegate* cache_delegate)

: RulesRegistry(profile,

event_name,

owner_thread,

- false /*log_storage_init_delay*/,

- ui_part) {}

+ cache_delegate) {}

std::string TestRulesRegistry::AddRulesImpl(

const std::string& extension_id,