chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h - Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache

Patch Set: Merge with ToT Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative/rules_registry.cc ('K') | « chrome/browser/extensions/api/declarative_content/content_rules_registry_unittest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

index 311fe19ae66b2125c1c7a4ebeee16985d9dc6fbc..1c174566432616d4a0f2d627b3a8ba283321d777 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

@@ -75,8 +75,7 @@ class WebRequestRulesRegistry : public RulesRegistry {

public:

// |cache_delegate| can be NULL. In that case it constructs the registry with

// storage functionality suspended.

- WebRequestRulesRegistry(Profile* profile,

- scoped_ptr<RulesCacheDelegate>* cache_delegate);

+ explicit WebRequestRulesRegistry(Profile* profile);

// TODO(battre): This will become an implementation detail, because we need

// a way to also execute the actions of the rules.