Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

Issue 53273002: Decouple RulesCacheDelegate from RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_rules_registry_with_cache
Patch Set: Merge with ToT Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_RE GISTRY_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_RE GISTRY_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_RE GISTRY_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES_RE GISTRY_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // represents the {'host_suffix': 'example.com', 'path_prefix': '/query'} part. 68 // represents the {'host_suffix': 'example.com', 'path_prefix': '/query'} part.
69 // We will then ask the URLMatcher, whether a given URL 69 // We will then ask the URLMatcher, whether a given URL
70 // "http://www.example.com/query/" has any matches, and the URLMatcher 70 // "http://www.example.com/query/" has any matches, and the URLMatcher
71 // will respond with the URLMatcherConditionSet::ID. We can map this 71 // will respond with the URLMatcherConditionSet::ID. We can map this
72 // to the WebRequestRule and check whether also the other conditions (in this 72 // to the WebRequestRule and check whether also the other conditions (in this
73 // example 'scheme': 'http') are fulfilled. 73 // example 'scheme': 'http') are fulfilled.
74 class WebRequestRulesRegistry : public RulesRegistry { 74 class WebRequestRulesRegistry : public RulesRegistry {
75 public: 75 public:
76 // |cache_delegate| can be NULL. In that case it constructs the registry with 76 // |cache_delegate| can be NULL. In that case it constructs the registry with
77 // storage functionality suspended. 77 // storage functionality suspended.
78 WebRequestRulesRegistry(Profile* profile, 78 explicit WebRequestRulesRegistry(Profile* profile);
79 scoped_ptr<RulesCacheDelegate>* cache_delegate);
80 79
81 // TODO(battre): This will become an implementation detail, because we need 80 // TODO(battre): This will become an implementation detail, because we need
82 // a way to also execute the actions of the rules. 81 // a way to also execute the actions of the rules.
83 std::set<const WebRequestRule*> GetMatches( 82 std::set<const WebRequestRule*> GetMatches(
84 const WebRequestData& request_data_without_ids) const; 83 const WebRequestData& request_data_without_ids) const;
85 84
86 // Returns which modifications should be executed on the network request 85 // Returns which modifications should be executed on the network request
87 // according to the rules registered in this registry. 86 // according to the rules registered in this registry.
88 std::list<LinkedPtrEventResponseDelta> CreateDeltas( 87 std::list<LinkedPtrEventResponseDelta> CreateDeltas(
89 const ExtensionInfoMap* extension_info_map, 88 const ExtensionInfoMap* extension_info_map,
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 182
184 void* profile_id_; 183 void* profile_id_;
185 scoped_refptr<ExtensionInfoMap> extension_info_map_; 184 scoped_refptr<ExtensionInfoMap> extension_info_map_;
186 185
187 DISALLOW_COPY_AND_ASSIGN(WebRequestRulesRegistry); 186 DISALLOW_COPY_AND_ASSIGN(WebRequestRulesRegistry);
188 }; 187 };
189 188
190 } // namespace extensions 189 } // namespace extensions
191 190
192 #endif // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES _REGISTRY_H_ 191 #endif // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_WEBREQUEST_WEBREQUEST_RULES _REGISTRY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698