Issue 532713002: Disable unit test because of NaCL breakage after r23617.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 532713002: Disable unit test because of NaCL breakage after r23617. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer, tfarina

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Disable unit test because of NaCL breakage after r23617. TBR=bmeurer@chromium.org TEST=base-unittests/BitsDeathTest.RoundUpToPowerOfTwo32 Committed: https://code.google.com/p/v8/source/detail?r=23621

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/base/bits-unittest.cc	View		1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Committed patchset #1 (id:1) manually as 23621 (tree was closed).

6 years, 3 months ago (2014-09-02 14:52:59 UTC) #2

tfarina

lgtm https://codereview.chromium.org/532713002/diff/1/src/base/bits-unittest.cc File src/base/bits-unittest.cc (right): https://codereview.chromium.org/532713002/diff/1/src/base/bits-unittest.cc#newcode89 src/base/bits-unittest.cc:89: TEST(BitsDeathTest, DISABLE_IN_RELEASE(RoundUpToPowerOfTwo32)) { I think you can also ...

6 years, 3 months ago (2014-09-02 16:46:02 UTC) #3

Michael Starzinger

6 years, 3 months ago (2014-09-02 16:55:58 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/532713002/diff/1/src/base/bits-unittest.cc
File src/base/bits-unittest.cc (right):

https://codereview.chromium.org/532713002/diff/1/src/base/bits-unittest.cc#ne...
src/base/bits-unittest.cc:89: TEST(BitsDeathTest,
DISABLE_IN_RELEASE(RoundUpToPowerOfTwo32)) {
On 2014/09/02 16:46:02, tfarina wrote:
> I think you can also disable this test with:
> 
> DISABLED_RoundUpToPowerOfTwo32
> 
> if it isn't just in release.

Nope, it was a compile failure, needed to be ifdef'ed away. Already fixed for
realz in r23625 courtesy of Jaro.

Expand Messages | Collapse Messages