Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: src/base/bits-unittest.cc

Issue 532713002: Disable unit test because of NaCL breakage after r23617. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/bits-unittest.cc
diff --git a/src/base/bits-unittest.cc b/src/base/bits-unittest.cc
index 188d14c533e182632ced2f2466a0e7cb824b6800..e0e6a5f1ef416ed29054a127cbc645a88ade36a3 100644
--- a/src/base/bits-unittest.cc
+++ b/src/base/bits-unittest.cc
@@ -84,9 +84,12 @@ TEST(Bits, RoundUpToPowerOfTwo32) {
}
+#if 0
+// TODO(bmeurer): Fix this on NaCL builds.
TEST(BitsDeathTest, DISABLE_IN_RELEASE(RoundUpToPowerOfTwo32)) {
tfarina 2014/09/02 16:46:02 I think you can also disable this test with: DISA
Michael Starzinger 2014/09/02 16:55:58 Nope, it was a compile failure, needed to be ifdef
ASSERT_DEATH({ RoundUpToPowerOfTwo32(0x80000001u); }, "0x80000000");
}
+#endif
TEST(Bits, RoundDownToPowerOfTwo32) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698