Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 532653002: ServiceWorker: Make '.ready' return a promise to be resolved with SWRegistration (3/3) (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@ready
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Make '.ready' return a promise to be resolved with ServiceWorkerRegistration (3/3) This enables and tweaks ready.html to follow up the implementation changes. 1) Blink: https://codereview.chromium.org/476043002/ 2) Chromium: https://codereview.chromium.org/477593007/ 3) Blink: THIS PATCH BUG=399533 TEST=run_webkit_tests.py --debug http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181806

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : remove unnecessary wait_for_activated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -37 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ready.html View 1 2 1 chunk +92 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nhiroki
Ptal, thanks!
6 years, 3 months ago (2014-09-10 08:13:11 UTC) #3
horo
https://codereview.chromium.org/532653002/diff/80001/LayoutTests/http/tests/serviceworker/ready.html File LayoutTests/http/tests/serviceworker/ready.html (right): https://codereview.chromium.org/532653002/diff/80001/LayoutTests/http/tests/serviceworker/ready.html#newcode73 LayoutTests/http/tests/serviceworker/ready.html:73: return wait_for_activated(t, registration); is this needed? https://codereview.chromium.org/532653002/diff/80001/LayoutTests/http/tests/serviceworker/ready.html#newcode130 LayoutTests/http/tests/serviceworker/ready.html:130: could ...
6 years, 3 months ago (2014-09-10 08:57:54 UTC) #4
nhiroki
https://codereview.chromium.org/532653002/diff/80001/LayoutTests/http/tests/serviceworker/ready.html File LayoutTests/http/tests/serviceworker/ready.html (right): https://codereview.chromium.org/532653002/diff/80001/LayoutTests/http/tests/serviceworker/ready.html#newcode73 LayoutTests/http/tests/serviceworker/ready.html:73: return wait_for_activated(t, registration); On 2014/09/10 08:57:54, horo wrote: > ...
6 years, 3 months ago (2014-09-11 08:16:37 UTC) #5
horo
lgtm
6 years, 3 months ago (2014-09-11 08:49:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/532653002/100001
6 years, 3 months ago (2014-09-11 09:01:20 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 09:25:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as 181806

Powered by Google App Engine
This is Rietveld 408576698