chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h - Issue 532623003: Remove MetricsServiceObserver in favor of MetricsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

Issue 532623003: Remove MetricsServiceObserver in favor of MetricsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_browser_metrics_service_observer.cc ('k') | chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc » ('j') | components/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

index ccccfd5b63052194913d723c3705b9c79a4b4baf..0e4fdbb9efc7aaad7612cd469ab0ee18e957b360 100644

--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

@@ -11,7 +11,6 @@

#include "chrome/browser/chrome_browser_main_extra_parts.h"

class ChromeBrowserMainParts;

-class ChromeBrowserMetricsServiceObserver;

namespace chrome {

void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts);

@@ -28,9 +27,6 @@ class ChromeBrowserMainExtraPartsMetrics : public ChromeBrowserMainExtraParts {

virtual void PostBrowserStart() OVERRIDE;

private:

- // Observe and log histograms on new metric logs.

- scoped_ptr<ChromeBrowserMetricsServiceObserver> metrics_service_observer_;

DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetrics);

};