chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc - Issue 532623003: Remove MetricsServiceObserver in favor of MetricsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 532623003: Remove MetricsServiceObserver in favor of MetricsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h ('k') | chrome/browser/metrics/chrome_metrics_service_accessor.h » ('j') | components/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

index 1b490fcff60f5d04563849532f82cd06989b32ed..fa1789f60460a8972216c0da4b73d5d385d50e98 100644

--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

@@ -17,7 +17,6 @@

#include "chrome/browser/about_flags.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_browser_main.h"

-#include "chrome/browser/chrome_browser_metrics_service_observer.h"

#include "chrome/browser/mac/bluetooth_utility.h"

#include "chrome/browser/pref_service_flags_storage.h"

#include "chrome/browser/shell_integration.h"

@@ -234,12 +233,6 @@ void ChromeBrowserMainExtraPartsMetrics::PostBrowserStart() {

FROM_HERE,

base::Bind(&RecordStartupMetricsOnBlockingPool),

base::TimeDelta::FromSeconds(kStartupMetricsGatheringDelaySeconds));

- // Create the metrics log observer.

- // We only need this for Android for now.

-#if defined(ANDROID)

- metrics_service_observer_.reset(new ChromeBrowserMetricsServiceObserver());

-#endif

}

namespace chrome {