Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 532453002: Handle the case when the last selection is not set yet. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Handle the case when the last selection is not set yet. When a user starts to drag an item before they haven't selected any item yet, FileTable.lastSelection_ can be undefined and this ends up an incorrect drag image. The existence of lastSelection_ should be checked. BUG=409514 TEST=manually Committed: https://crrev.com/60a533c07f2e01cb06e17d829a7972fa9a1b2984 Cr-Commit-Position: refs/heads/master@{#292845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_table.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
@hirono, PTAL the CL? Thanks!
6 years, 3 months ago (2014-09-01 06:36:17 UTC) #2
hirono
lgtm!
6 years, 3 months ago (2014-09-01 06:42:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/532453002/1
6 years, 3 months ago (2014-09-01 06:44:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a8f3e814e770c0044298f4a9af2e3b4ea6820c62
6 years, 3 months ago (2014-09-01 08:12:09 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60a533c07f2e01cb06e17d829a7972fa9a1b2984
Cr-Commit-Position: refs/heads/master@{#292845}

Powered by Google App Engine
This is Rietveld 408576698