ui/file_manager/file_manager/foreground/js/file_table.js - Issue 532453002: Handle the case when the last selection is not set yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_table.js

Issue 532453002: Handle the case when the last selection is not set yet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/file_table.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_table.js b/ui/file_manager/file_manager/foreground/js/file_table.js

index e7d063e7281e471f5d58dbb6e07e444e66a5ee71..9f4bb016670938a892d60e49a634730eafdf2c19 100644

--- a/ui/file_manager/file_manager/foreground/js/file_table.js

+++ b/ui/file_manager/file_manager/foreground/js/file_table.js

@@ -395,7 +395,7 @@ FileTable.prototype.shouldStartDragSelection_ = function(event) {

// If the pointed item is already selected, it should not start the drag

// selection.

- if (this.lastSelection_.indexOf(itemIndex) !== -1)

+ if (this.lastSelection_ && this.lastSelection_.indexOf(itemIndex) !== -1)

return false;

// If the horizontal value is not hit to column, it should start the drag

« no previous file with comments | « no previous file | no next file » | no next file with comments »