Inlining references to internal APIs.

Inlining references to internal APIs.

BUG=402763
Committed: https://crrev.com/2e86410f7ce038c58810b2268c38b177a3803ea8
Cr-Commit-Position: refs/heads/master@{#293385}

[lfg, 2014-09-03 21:51:43]

lfg@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-09-04 01:57:12]

Looks good in general, some comments:

https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/process_schema.py (right):

https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/server2/process_schema.py:53: class
ProcessSchema(object):
This name made sense for a function, but does not make sense for a class. Please
rename to SchemaProcessor and have other similarly named classes follow suit.
Sorry, I know it will probably be an annoying change to make.

https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/reference_resolver.py (right):

https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
chrome/common/extensions/docs/server2/reference_resolver.py:110: def
GetRefModel(self, ref, api_list):
Please include a docstring to explain what this does and returns.

https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
File extensions/common/api/_api_features.json (right):

https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
extensions/common/api/_api_features.json:43: "extensionTypes": {
Please preserve the "not a real API" disclaimer from the chrome features file.

Also I guess this doesn't really need to move since it's only for chrome
documentation, but apparently we (probably I) moved the interface file, soo...
:)  might as well do this too.

[lfg, 2014-09-04 15:16:02]

On 2014/09/04 01:57:12, Ken Rockot wrote:
> Looks good in general, some comments:
> 
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> File chrome/common/extensions/docs/server2/process_schema.py (right):
> 
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> chrome/common/extensions/docs/server2/process_schema.py:53: class
> ProcessSchema(object):
> This name made sense for a function, but does not make sense for a class.
Please
> rename to SchemaProcessor and have other similarly named classes follow suit.
> Sorry, I know it will probably be an annoying change to make.

Done.

>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> File chrome/common/extensions/docs/server2/reference_resolver.py (right):
> 
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> chrome/common/extensions/docs/server2/reference_resolver.py:110: def
> GetRefModel(self, ref, api_list):
> Please include a docstring to explain what this does and returns.

Done.

>
https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
> File extensions/common/api/_api_features.json (right):
> 
>
https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
> extensions/common/api/_api_features.json:43: "extensionTypes": {
> Please preserve the "not a real API" disclaimer from the chrome features file.
> 
> Also I guess this doesn't really need to move since it's only for chrome
> documentation, but apparently we (probably I) moved the interface file, soo...
> :)  might as well do this too.

Well, about this... :)

So, I had to move types.ImageDetails from chrome to extensions, and since we
don't support merging namespaces from chrome and extensions, when I moved it I
had to rename it, and the obvious name was extensionTypes (see
https://codereview.chromium.org/487533005/ ). I didn't realize extensionTypes
"namespace" was already used for other things, and extensionTypes became a real
API. Maybe we should rename it? Suggestions?

[Ken Rockot(use gerrit already), 2014-09-04 16:24:22]

On 2014/09/04 15:16:02, lfg wrote:
> On 2014/09/04 01:57:12, Ken Rockot wrote:
> > Looks good in general, some comments:
> > 
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > File chrome/common/extensions/docs/server2/process_schema.py (right):
> > 
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > chrome/common/extensions/docs/server2/process_schema.py:53: class
> > ProcessSchema(object):
> > This name made sense for a function, but does not make sense for a class.
> Please
> > rename to SchemaProcessor and have other similarly named classes follow
suit.
> > Sorry, I know it will probably be an annoying change to make.
> 
> Done.
> 
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > File chrome/common/extensions/docs/server2/reference_resolver.py (right):
> > 
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > chrome/common/extensions/docs/server2/reference_resolver.py:110: def
> > GetRefModel(self, ref, api_list):
> > Please include a docstring to explain what this does and returns.
> 
> Done.
> 
> >
>
https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
> > File extensions/common/api/_api_features.json (right):
> > 
> >
>
https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
> > extensions/common/api/_api_features.json:43: "extensionTypes": {
> > Please preserve the "not a real API" disclaimer from the chrome features
file.
> > 
> > Also I guess this doesn't really need to move since it's only for chrome
> > documentation, but apparently we (probably I) moved the interface file,
soo...
> > :)  might as well do this too.
> 
> Well, about this... :)
> 
> So, I had to move types.ImageDetails from chrome to extensions, and since we
> don't support merging namespaces from chrome and extensions, when I moved it I
> had to rename it, and the obvious name was extensionTypes (see
> https://codereview.chromium.org/487533005/ ). I didn't realize extensionTypes
> "namespace" was already used for other things, and extensionTypes became a
real
> API. Maybe we should rename it? Suggestions?

I'm confused about the "real API" part - extensionTypes is not a real API is it?

[lfg, 2014-09-04 16:27:34]

On 2014/09/04 16:24:22, Ken Rockot wrote:
> On 2014/09/04 15:16:02, lfg wrote:
> > On 2014/09/04 01:57:12, Ken Rockot wrote:
> > > Looks good in general, some comments:
> > > 
> > >
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > > File chrome/common/extensions/docs/server2/process_schema.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > > chrome/common/extensions/docs/server2/process_schema.py:53: class
> > > ProcessSchema(object):
> > > This name made sense for a function, but does not make sense for a class.
> > Please
> > > rename to SchemaProcessor and have other similarly named classes follow
> suit.
> > > Sorry, I know it will probably be an annoying change to make.
> > 
> > Done.
> > 
> > >
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > > File chrome/common/extensions/docs/server2/reference_resolver.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/532423002/diff/40001/chrome/common/extensions...
> > > chrome/common/extensions/docs/server2/reference_resolver.py:110: def
> > > GetRefModel(self, ref, api_list):
> > > Please include a docstring to explain what this does and returns.
> > 
> > Done.
> > 
> > >
> >
>
https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
> > > File extensions/common/api/_api_features.json (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/532423002/diff/40001/extensions/common/api/_a...
> > > extensions/common/api/_api_features.json:43: "extensionTypes": {
> > > Please preserve the "not a real API" disclaimer from the chrome features
> file.
> > > 
> > > Also I guess this doesn't really need to move since it's only for chrome
> > > documentation, but apparently we (probably I) moved the interface file,
> soo...
> > > :)  might as well do this too.
> > 
> > Well, about this... :)
> > 
> > So, I had to move types.ImageDetails from chrome to extensions, and since we
> > don't support merging namespaces from chrome and extensions, when I moved it
I
> > had to rename it, and the obvious name was extensionTypes (see
> > https://codereview.chromium.org/487533005/ ). I didn't realize
extensionTypes
> > "namespace" was already used for other things, and extensionTypes became a
> real
> > API. Maybe we should rename it? Suggestions?
> 
> I'm confused about the "real API" part - extensionTypes is not a real API is
it?

I guess it depends on the definition of real API. It defines types:

https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

[Ken Rockot(use gerrit already), 2014-09-04 16:33:25]

Ah OK - Yeah I don't think the actual type name is exposed to script
contexts though. i.e. you shouldn't be able to say "new
chrome.extensionTypes.ImageDetails" - the naming is just there for
documentation references. I think this is fine.

LGTM!


On Thu, Sep 4, 2014 at 9:27 AM, <lfg@chromium.org> wrote:

> On 2014/09/04 16:24:22, Ken Rockot wrote:
>
>> On 2014/09/04 15:16:02, lfg wrote:
>> > On 2014/09/04 01:57:12, Ken Rockot wrote:
>> > > Looks good in general, some comments:
>> > >
>> > >
>> >
>>
>
> https://codereview.chromium.org/532423002/diff/40001/
> chrome/common/extensions/docs/server2/process_schema.py
>
>> > > File chrome/common/extensions/docs/server2/process_schema.py (right):
>> > >
>> > >
>> >
>>
>
> https://codereview.chromium.org/532423002/diff/40001/
> chrome/common/extensions/docs/server2/process_schema.py#newcode53
>
>> > > chrome/common/extensions/docs/server2/process_schema.py:53: class
>> > > ProcessSchema(object):
>> > > This name made sense for a function, but does not make sense for a
>> class.
>> > Please
>> > > rename to SchemaProcessor and have other similarly named classes
>> follow
>> suit.
>> > > Sorry, I know it will probably be an annoying change to make.
>> >
>> > Done.
>> >
>> > >
>> >
>>
>
> https://codereview.chromium.org/532423002/diff/40001/
> chrome/common/extensions/docs/server2/reference_resolver.py
>
>> > > File chrome/common/extensions/docs/server2/reference_resolver.py
>> (right):
>> > >
>> > >
>> >
>>
>
> https://codereview.chromium.org/532423002/diff/40001/
> chrome/common/extensions/docs/server2/reference_resolver.py#newcode110
>
>> > > chrome/common/extensions/docs/server2/reference_resolver.py:110: def
>> > > GetRefModel(self, ref, api_list):
>> > > Please include a docstring to explain what this does and returns.
>> >
>> > Done.
>> >
>> > >
>> >
>>
>
> https://codereview.chromium.org/532423002/diff/40001/
> extensions/common/api/_api_features.json
>
>> > > File extensions/common/api/_api_features.json (right):
>> > >
>> > >
>> >
>>
>
> https://codereview.chromium.org/532423002/diff/40001/
> extensions/common/api/_api_features.json#newcode43
>
>> > > extensions/common/api/_api_features.json:43: "extensionTypes": {
>> > > Please preserve the "not a real API" disclaimer from the chrome
>> features
>> file.
>> > >
>> > > Also I guess this doesn't really need to move since it's only for
>> chrome
>> > > documentation, but apparently we (probably I) moved the interface
>> file,
>> soo...
>> > > :)  might as well do this too.
>> >
>> > Well, about this... :)
>> >
>> > So, I had to move types.ImageDetails from chrome to extensions, and
>> since we
>> > don't support merging namespaces from chrome and extensions, when I
>> moved it
>>
> I
>
>> > had to rename it, and the obvious name was extensionTypes (see
>> > https://codereview.chromium.org/487533005/ ). I didn't realize
>>
> extensionTypes
>
>> > "namespace" was already used for other things, and extensionTypes
>> became a
>> real
>> > API. Maybe we should rename it? Suggestions?
>>
>
>  I'm confused about the "real API" part - extensionTypes is not a real API
>> is
>>
> it?
>
> I guess it depends on the definition of real API. It defines types:
>
> https://code.google.com/p/chromium/codesearch#chromium/
> src/extensions/common/api/extension_types.json
>
>
> https://codereview.chromium.org/532423002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2014-09-04 16:33:47]

lgtm

[lfg, 2014-09-04 16:42:32]

Ah, I see what you mean. I'll re-add the comment on _api_features.json.

On 2014/09/04 16:33:25, Ken Rockot wrote:
> Ah OK - Yeah I don't think the actual type name is exposed to script
> contexts though. i.e. you shouldn't be able to say "new
> chrome.extensionTypes.ImageDetails" - the naming is just there for
> documentation references. I think this is fine.
> 
> LGTM!
> 
> 
> On Thu, Sep 4, 2014 at 9:27 AM, <mailto:lfg@chromium.org> wrote:
> 
> > On 2014/09/04 16:24:22, Ken Rockot wrote:
> >
> >> On 2014/09/04 15:16:02, lfg wrote:
> >> > On 2014/09/04 01:57:12, Ken Rockot wrote:
> >> > > Looks good in general, some comments:
> >> > >
> >> > >
> >> >
> >>
> >
> > https://codereview.chromium.org/532423002/diff/40001/
> > chrome/common/extensions/docs/server2/process_schema.py
> >
> >> > > File chrome/common/extensions/docs/server2/process_schema.py (right):
> >> > >
> >> > >
> >> >
> >>
> >
> > https://codereview.chromium.org/532423002/diff/40001/
> > chrome/common/extensions/docs/server2/process_schema.py#newcode53
> >
> >> > > chrome/common/extensions/docs/server2/process_schema.py:53: class
> >> > > ProcessSchema(object):
> >> > > This name made sense for a function, but does not make sense for a
> >> class.
> >> > Please
> >> > > rename to SchemaProcessor and have other similarly named classes
> >> follow
> >> suit.
> >> > > Sorry, I know it will probably be an annoying change to make.
> >> >
> >> > Done.
> >> >
> >> > >
> >> >
> >>
> >
> > https://codereview.chromium.org/532423002/diff/40001/
> > chrome/common/extensions/docs/server2/reference_resolver.py
> >
> >> > > File chrome/common/extensions/docs/server2/reference_resolver.py
> >> (right):
> >> > >
> >> > >
> >> >
> >>
> >
> > https://codereview.chromium.org/532423002/diff/40001/
> > chrome/common/extensions/docs/server2/reference_resolver.py#newcode110
> >
> >> > > chrome/common/extensions/docs/server2/reference_resolver.py:110: def
> >> > > GetRefModel(self, ref, api_list):
> >> > > Please include a docstring to explain what this does and returns.
> >> >
> >> > Done.
> >> >
> >> > >
> >> >
> >>
> >
> > https://codereview.chromium.org/532423002/diff/40001/
> > extensions/common/api/_api_features.json
> >
> >> > > File extensions/common/api/_api_features.json (right):
> >> > >
> >> > >
> >> >
> >>
> >
> > https://codereview.chromium.org/532423002/diff/40001/
> > extensions/common/api/_api_features.json#newcode43
> >
> >> > > extensions/common/api/_api_features.json:43: "extensionTypes": {
> >> > > Please preserve the "not a real API" disclaimer from the chrome
> >> features
> >> file.
> >> > >
> >> > > Also I guess this doesn't really need to move since it's only for
> >> chrome
> >> > > documentation, but apparently we (probably I) moved the interface
> >> file,
> >> soo...
> >> > > :)  might as well do this too.
> >> >
> >> > Well, about this... :)
> >> >
> >> > So, I had to move types.ImageDetails from chrome to extensions, and
> >> since we
> >> > don't support merging namespaces from chrome and extensions, when I
> >> moved it
> >>
> > I
> >
> >> > had to rename it, and the obvious name was extensionTypes (see
> >> > https://codereview.chromium.org/487533005/ ). I didn't realize
> >>
> > extensionTypes
> >
> >> > "namespace" was already used for other things, and extensionTypes
> >> became a
> >> real
> >> > API. Maybe we should rename it? Suggestions?
> >>
> >
> >  I'm confused about the "real API" part - extensionTypes is not a real API
> >> is
> >>
> > it?
> >
> > I guess it depends on the definition of real API. It defines types:
> >
> > https://code.google.com/p/chromium/codesearch#chromium/
> > src/extensions/common/api/extension_types.json
> >
> >
> > https://codereview.chromium.org/532423002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[lfg, 2014-09-04 19:23:18]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-04 19:25:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lfg@chromium.org/532423002/80001

[commit-bot: I haz the power, 2014-09-05 00:58:41]

Committed patchset #5 (id:80001) as 10f9a6569ef7ce0ec75c5519e8d034a7763389eb

[commit-bot: I haz the power, 2014-09-10 03:34:26]

Patchset 5 (id:??) landed as
https://crrev.com/2e86410f7ce038c58810b2268c38b177a3803ea8
Cr-Commit-Position: refs/heads/master@{#293385}