Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5091)

Unified Diff: chrome/common/extensions/docs/server2/schema_processor_test.py

Issue 532423002: Inlining references to internal APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-adding comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/schema_processor_test.py
diff --git a/chrome/common/extensions/docs/server2/schema_util_test.py b/chrome/common/extensions/docs/server2/schema_processor_test.py
similarity index 61%
rename from chrome/common/extensions/docs/server2/schema_util_test.py
rename to chrome/common/extensions/docs/server2/schema_processor_test.py
index 3be428cce412ce5fd4375f5cce66cad6bde53494..7530d453a22c7332d91fc3e32a20ed0afe29baab 100755
--- a/chrome/common/extensions/docs/server2/schema_util_test.py
+++ b/chrome/common/extensions/docs/server2/schema_processor_test.py
@@ -6,11 +6,25 @@
import unittest
from copy import deepcopy
-from schema_util import RemoveNoDocs, DetectInlineableTypes, InlineDocs
+from schema_processor import SchemaProcessor
+from future import Future
+from object_store_creator import ObjectStoreCreator
+from host_file_system_provider import HostFileSystemProvider
+from compiled_file_system import CompiledFileSystem
+class _FakeReferenceResolver():
+ def GetRefModel(self, ref, api_list):
+ return None, None
-class SchemaUtilTest(unittest.TestCase):
+class _FakeAPIModels():
+ def GetNames(self):
+ return []
+
+class _FakeFeaturesBundle():
+ def GetAPIFeatures(self):
+ return Future(value={})
+class SchemaUtilTest(unittest.TestCase):
def testRemoveNoDocs(self):
expected_nodoc = [
{
@@ -106,7 +120,16 @@ class SchemaUtilTest(unittest.TestCase):
}
]
- RemoveNoDocs(nodoc_data)
+ object_store_creator = ObjectStoreCreator(start_empty=False)
+ host_file_system_provider = HostFileSystemProvider(object_store_creator)
+ schema_processor = SchemaProcessor(_FakeReferenceResolver(),
+ _FakeAPIModels(),
+ _FakeFeaturesBundle(),
+ CompiledFileSystem.Factory(
+ object_store_creator),
+ host_file_system_provider.GetTrunk(),
+ True)
+ schema_processor._RemoveNoDocs(nodoc_data)
self.assertEquals(expected_nodoc, nodoc_data)
def testInlineDocs(self):
@@ -169,8 +192,17 @@ class SchemaUtilTest(unittest.TestCase):
]
}
+ object_store_creator = ObjectStoreCreator(start_empty=False)
+ host_file_system_provider = HostFileSystemProvider(object_store_creator)
+ schema_processor = SchemaProcessor(_FakeReferenceResolver(),
+ _FakeAPIModels(),
+ _FakeFeaturesBundle(),
+ CompiledFileSystem.Factory(
+ object_store_creator),
+ host_file_system_provider.GetTrunk(),
+ False)
inlined_schema = deepcopy(schema)
- InlineDocs(inlined_schema, False)
+ schema_processor._InlineDocs(inlined_schema)
self.assertEqual(expected_schema, inlined_schema)
def testDetectInline(self):
@@ -200,8 +232,17 @@ class SchemaUtilTest(unittest.TestCase):
]
}
- DetectInlineableTypes(schema)
- InlineDocs(schema, False)
+ object_store_creator = ObjectStoreCreator(start_empty=False)
+ host_file_system_provider = HostFileSystemProvider(object_store_creator)
+ schema_processor = SchemaProcessor(_FakeReferenceResolver(),
+ _FakeAPIModels(),
+ _FakeFeaturesBundle(),
+ CompiledFileSystem.Factory(
+ object_store_creator),
+ host_file_system_provider.GetTrunk(),
+ False)
+ schema_processor._DetectInlineableTypes(schema)
+ schema_processor._InlineDocs(schema)
self.assertEqual(expected_schema, schema)
« no previous file with comments | « chrome/common/extensions/docs/server2/schema_processor.py ('k') | chrome/common/extensions/docs/server2/schema_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698