Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: Source/core/loader/TextTrackLoader.cpp

Issue 53213002: Handle resource fetch failure in TextTrackLoader::load (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@refTextTrackLoaderClient
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/TextTrackLoader.cpp
diff --git a/Source/core/loader/TextTrackLoader.cpp b/Source/core/loader/TextTrackLoader.cpp
index 1d442a7e0defe393c0ee8723c98c320529eaf504..b20ed16661a62a35eabafed296c91147f51363a8 100644
--- a/Source/core/loader/TextTrackLoader.cpp
+++ b/Source/core/loader/TextTrackLoader.cpp
@@ -138,8 +138,10 @@ bool TextTrackLoader::load(const KURL& url, const String& crossOriginMode)
ResourceFetcher* fetcher = m_document.fetcher();
m_resource = fetcher->fetchRawResource(cueRequest);
- if (m_resource)
- m_resource->addClient(this);
+ if (!m_resource)
+ return false;
+
+ m_resource->addClient(this);
philipj_slow 2013/10/30 20:01:51 Too many blank lines around here? http://www.chrom
Nate Chapin 2013/10/30 20:06:10 The rules on blank lines are pretty loose. I'd lea
philipj_slow 2013/10/30 20:13:57 I've always wanted to be like you, so I'll go with
m_client.cueLoadingStarted(this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698