Handle resource fetch failure in TextTrackLoader::load

Source/core/loader/TextTrackLoader.cpp

Index: Source/core/loader/TextTrackLoader.cpp
diff --git a/Source/core/loader/TextTrackLoader.cpp b/Source/core/loader/TextTrackLoader.cpp
index 1d442a7e0defe393c0ee8723c98c320529eaf504..b20ed16661a62a35eabafed296c91147f51363a8 100644
--- a/Source/core/loader/TextTrackLoader.cpp
+++ b/Source/core/loader/TextTrackLoader.cpp
@@ -138,8 +138,10 @@ bool TextTrackLoader::load(const KURL& url, const String& crossOriginMode)
 
     ResourceFetcher* fetcher = m_document.fetcher();
     m_resource = fetcher->fetchRawResource(cueRequest);
-    if (m_resource)
-        m_resource->addClient(this);
+    if (!m_resource)
+        return false;
+
+    m_resource->addClient(this);

[philipj_slow, 2013/10/30 20:01:51]

Too many blank lines around here? http://www.chromium.org/blink/coding-style
doesn't give any clear answers.

[Nate Chapin, 2013/10/30 20:06:10]

The rules on blank lines are pretty loose. I'd lean against a blank line there,
but if it were me, I would probably have written everything from:
    ResourceFetcher* fetcher = m_document.fetcher();
to:
    return true;

...without blank lines, on the logic that they're all part of the same concept
of actually starting the load. I tend to underuse blank lines :)

[philipj_slow, 2013/10/30 20:13:57]

I've always wanted to be like you, so I'll go with that :)

 
     m_client.cueLoadingStarted(this);