Handle resource fetch failure in TextTrackLoader::load

Source/core/loader/TextTrackLoader.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 120 matching lines @@
     } else {
         // Cross-origin resources that are not suitably CORS-enabled may not load.
         if (!m_document.securityOrigin()->canRequest(url)) {
             corsPolicyPreventedLoad();
             return false;
         }
     }
 
     ResourceFetcher* fetcher = m_document.fetcher();
     m_resource = fetcher->fetchRawResource(cueRequest);
-    if (m_resource)
-        m_resource->addClient(this);
+    if (!m_resource)
+        return false;
+
+    m_resource->addClient(this);

[philipj_slow, 2013/10/30 20:01:51]

Too many blank lines around here? http://www.chromium.org/blink/coding-style
doesn't give any clear answers.

[Nate Chapin, 2013/10/30 20:06:10]

The rules on blank lines are pretty loose. I'd lean against a blank line there,
but if it were me, I would probably have written everything from:
    ResourceFetcher* fetcher = m_document.fetcher();
to:
    return true;

...without blank lines, on the logic that they're all part of the same concept
of actually starting the load. I tend to underuse blank lines :)

[philipj_slow, 2013/10/30 20:13:57]

I've always wanted to be like you, so I'll go with that :)

 
     m_client.cueLoadingStarted(this);
 
     return true;
 }
 
 void TextTrackLoader::newCuesParsed()
 {
     if (m_cueLoadTimer.isActive())
         return;
@@ skipping 27 matching lines @@
 }
 
 void TextTrackLoader::getNewRegions(Vector<RefPtr<TextTrackRegion> >& outputRegions)
 {
     ASSERT(m_cueParser);
     if (m_cueParser)
         m_cueParser->getNewRegions(outputRegions);
 }
 }