runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart - Issue 532063002: Teach the Observatory about Contexts. Factor out object graph information from the instance view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

Issue 532063002: Teach the Observatory about Contexts. Factor out object graph information from the instance view. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/object_common.html ('k') | runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

index 4fe18be3338ec6987573f505d919e3bcfd79afd2..53383c0f165c552bbd26ff9aebfca5b18ab5e91f 100644

--- a/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

@@ -74,6 +74,10 @@ class AnyServiceRefElement extends ObservatoryElement {

ServiceRefElement element = new Element.tag('code-ref');

element.ref = ref;

return element;

+ case 'Context':

+ ServiceRefElement element = new Element.tag('context-ref');

Cutch 2014/09/03 22:06:49 Why not "var element" here and elsewhere?

rmacnak 2014/09/03 22:44:06 Fast failure when custom element isn't registered.

+ element.ref = ref;

+ return element;

case 'Error':

ServiceRefElement element = new Element.tag('error-ref');

element.ref = ref;