Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: runtime/bin/vmservice/observatory/lib/src/elements/service_ref.dart

Issue 532063002: Teach the Observatory about Contexts. Factor out object graph information from the instance view. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library service_ref_element; 5 library service_ref_element;
6 6
7 import 'dart:html'; 7 import 'dart:html';
8 import 'package:logging/logging.dart'; 8 import 'package:logging/logging.dart';
9 import 'package:polymer/polymer.dart'; 9 import 'package:polymer/polymer.dart';
10 import 'observatory_element.dart'; 10 import 'observatory_element.dart';
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 var type = ref.vmType; 67 var type = ref.vmType;
68 switch (type) { 68 switch (type) {
69 case 'Class': 69 case 'Class':
70 ServiceRefElement element = new Element.tag('class-ref'); 70 ServiceRefElement element = new Element.tag('class-ref');
71 element.ref = ref; 71 element.ref = ref;
72 return element; 72 return element;
73 case 'Code': 73 case 'Code':
74 ServiceRefElement element = new Element.tag('code-ref'); 74 ServiceRefElement element = new Element.tag('code-ref');
75 element.ref = ref; 75 element.ref = ref;
76 return element; 76 return element;
77 case 'Context':
78 ServiceRefElement element = new Element.tag('context-ref');
Cutch 2014/09/03 22:06:49 Why not "var element" here and elsewhere?
rmacnak 2014/09/03 22:44:06 Fast failure when custom element isn't registered.
79 element.ref = ref;
80 return element;
77 case 'Error': 81 case 'Error':
78 ServiceRefElement element = new Element.tag('error-ref'); 82 ServiceRefElement element = new Element.tag('error-ref');
79 element.ref = ref; 83 element.ref = ref;
80 return element; 84 return element;
81 case 'Field': 85 case 'Field':
82 ServiceRefElement element = new Element.tag('field-ref'); 86 ServiceRefElement element = new Element.tag('field-ref');
83 element.ref = ref; 87 element.ref = ref;
84 return element; 88 return element;
85 case 'Function': 89 case 'Function':
86 ServiceRefElement element = new Element.tag('function-ref'); 90 ServiceRefElement element = new Element.tag('function-ref');
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 var type = ref.vmType; 127 var type = ref.vmType;
124 var element = _constructElementForRef(); 128 var element = _constructElementForRef();
125 if (element == null) { 129 if (element == null) {
126 Logger.root.info('Unable to find a ref element for \'${type}\''); 130 Logger.root.info('Unable to find a ref element for \'${type}\'');
127 return; 131 return;
128 } 132 }
129 children.add(element); 133 children.add(element);
130 Logger.root.info('Viewing object of \'${type}\''); 134 Logger.root.info('Viewing object of \'${type}\'');
131 } 135 }
132 } 136 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698