Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 531963002: Add support for file inputs for all guest views (Closed)

Created:
6 years, 3 months ago by ericzeng
Modified:
6 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for file inputs for all guest views Implement WebContentsDelegate::RunFileChooser in GuestViewBase so that <input type=file> tags will work correctly within guest views. BUG=409339 Committed: https://crrev.com/95edbdf188e0208ba31570c24b8d7baae52de634 Cr-Commit-Position: refs/heads/master@{#293044}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement RunFileChooser as GuestViewBase method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M extensions/browser/guest_view/guest_view_base.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ericzeng
6 years, 3 months ago (2014-09-02 21:31:32 UTC) #2
Fady Samuel
https://codereview.chromium.org/531963002/diff/1/chrome/browser/guest_view/extension_options/extension_options_guest.cc File chrome/browser/guest_view/extension_options/extension_options_guest.cc (right): https://codereview.chromium.org/531963002/diff/1/chrome/browser/guest_view/extension_options/extension_options_guest.cc#newcode176 chrome/browser/guest_view/extension_options/extension_options_guest.cc:176: void ExtensionOptionsGuest::RunFileChooser( Could we please move this to GuestViewBase ...
6 years, 3 months ago (2014-09-02 21:34:19 UTC) #3
ericzeng
https://codereview.chromium.org/531963002/diff/1/chrome/browser/guest_view/extension_options/extension_options_guest.cc File chrome/browser/guest_view/extension_options/extension_options_guest.cc (right): https://codereview.chromium.org/531963002/diff/1/chrome/browser/guest_view/extension_options/extension_options_guest.cc#newcode176 chrome/browser/guest_view/extension_options/extension_options_guest.cc:176: void ExtensionOptionsGuest::RunFileChooser( On 2014/09/02 21:34:18, Fady Samuel wrote: > ...
6 years, 3 months ago (2014-09-02 23:07:30 UTC) #4
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-02 23:15:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/531963002/20001
6 years, 3 months ago (2014-09-02 23:19:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c2c410650023b3d74cad6b43b59661fb49cec760
6 years, 3 months ago (2014-09-03 01:46:10 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:40 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/95edbdf188e0208ba31570c24b8d7baae52de634
Cr-Commit-Position: refs/heads/master@{#293044}

Powered by Google App Engine
This is Rietveld 408576698